Skip to content

schedule: Add more restriction to descript gpu - #154

Open
yadej wants to merge 1 commit into
xtc-tools:mainfrom
yadej:dev/rcesista/fix-gpu-descript
Open

yadej wants to merge 1 commit into
xtc-tools:mainfrom
yadej:dev/rcesista/fix-gpu-descript

Conversation

@yadej

@yadej yadej commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Motivation

Some gpu schedule should not be possible so I add more validation at the loop nest level
Among the checking

  • We need gpu_block to take an axis
  • We need gpu_thread, gpu_lane or gpu_warp to be a tile
  • We can't have a loop before the gpu_block because that does not pass the compilation part but most importantly it would be making a operator making a lot of kernel

@yadej
yadej requested a review from guillon October 7, 2026 08:28
- Add some gpu validation test
- Regen some test
@yadej
yadej force-pushed the dev/rcesista/fix-gpu-descript branch from 63ba90d to eb5b583 Compare October 7, 2026 08:32
@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 19.23077% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/xtc/schedules/parameter_loop_nest.py 7.14% 13 Missing ⚠️
src/xtc/schedules/loop_nest.py 33.33% 4 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@yadej yadej added the enhancement New feature or request label Oct 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants