Skip to content

This closes #20, fix leading plus operator parsing in formulas - #21

Merged
xuri merged 2 commits into
xuri:masterfrom
wangyica879112:master
Sep 21, 2026
Merged

xuri merged 2 commits into
xuri:masterfrom
wangyica879112:master

Conversation

@wangyica879112

Copy link
Copy Markdown
Contributor

PR Details

This closes #20, fix leading plus operator parsing in formulas

Description

  • Preserve a leading + as an OperatorInfix token with subtype Math when another token follows
  • Add test formula to TestEFP function
  • Remove ARM, ARM64, Android, and RISC-V cross-compilation checks from pipline

Related Issue

#20

Motivation and Context

This closes #20, fix leading plus operator parsing in formulas

How Has This Been Tested

Add unit test cases for the changes, and all unit tests passed

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2026
@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b175812) to head (b0b89d4).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          381       384    +3     
=========================================
+ Hits           381       384    +3     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xuri xuri left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri
xuri merged commit 9199f39 into xuri:master Sep 21, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External reference parsing error

2 participants