Fix escaped quotes when rendering formulas - #23
Merged
Merged
Conversation
Problem: Render emitted logical embedded quotes raw instead of Excel's doubled-quote encoding. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Ngoc Trung <mr.trung.dhbk@gmail.com>
xuri
added
the
size/M
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 384 384
=========================================
Hits 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xuri
approved these changes
Sep 24, 2026
xuri
left a comment
xuri
left a comment
Owner
There was a problem hiding this comment.
Thanks for your contribution. I've made some changes based on your branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tokenizer stores doubled Excel quotes as one logical quote.
Renderemitted it raw and corrupted formula.Fix
Re-encode logical embedded quotes as doubled quotes for text tokens.
RED exact output:
GREEN:
TestRenderPreservesEscapedDoubleQuotespasses.Verification
go test -run '^TestRenderPreservesEscapedDoubleQuotes$' ./...go test ./...go test -race -cover ./...go vet ./...Scope
efp.go,efp_test.goFixes #22
Checklist
go test ./...passesgo test -race -cover ./...passesgo vet ./...passes