Conversation
|
Skeleton bullet outline for the v1 RC announcement so Yam can fill in prose later. Marked draft so it stays out of production listing/RSS. Co-authored-by: Yam Borodetsky <hi@yam.codes>
Surface three product highlights for first-time readers alongside the existing RC / migrate skeleton so Yam can expand them into prose later. Co-authored-by: Yam Borodetsky <hi@yam.codes>
…sidebar Replace the hero progress-bar chip with the Release Candidate announcement linking to /blog/arkenv-v1-rc, and surface the v1 progress meter in the docs sidebar banner instead. Co-authored-by: Yam Borodetsky <hi@yam.codes>
573db10 to
c66b42a
Compare
There was a problem hiding this comment.
Important
The new hero announcement points at /blog/arkenv-v1-rc, but that post is still draft: true, so in production the homepage CTA resolves to a 404. Un-draft it (and swap the internal "Outline for…" description for public copy) before this ships, or keep the badge on the migration guide until the post is live.
Reviewed changes
- Hero announcement retargeted —
ReleaseChannelBadgehref moves from/docs/guides/migrating-to-v1to/blog/arkenv-v1-rc; its unit test is updated to match. - Roadmap meter relocated —
RoadmapProgressCardstops wrappingAnnouncementBadgeand becomes a borderednext/linkcard; the homepage hero drops it, andapp/docs/layout.tsxrenders it via Fumadocssidebar.banner. - fumadocs-ui banner plumbing —
DrillInSidebarnow forwardsSidebarProps.bannerinto the desktopDrillInNavand the mobileAccordionNavinstead of discarding it (_banner). - Draft RC blog outline —
apps/www/content/blog/arkenv-v1-rc.mdxadded withdraft: true, covering RC status, newcomer bullets, v0 migration, and links to the migration guide.
ℹ️ Nitpicks
- The MDX
description(Outline for the v1 RC announcement — packages, docs cutover, migrating from v0, and what newcomers get.) is an internal note that becomes the public blog lede and OG description once the post is published — replace it with reader-facing copy along with thedraftflip.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
@arkenv/agent-plugin
arkenv
@arkenv/build
@arkenv/bun-plugin
@arkenv/core
@arkenv/fumadocs-ui
@arkenv/nextjs
@arkenv/nuxt
@arkenv/rsbuild-plugin
@arkenv/standard
@arkenv/tanstack-addon
@arkenv/vite-plugin
commit: |
There was a problem hiding this comment.
Important
The hero announcement still targets /blog/arkenv-v1-rc, which is draft: true — the CTA 404s in production (drafts only render under next dev). This was raised in the prior review and the rebase did not change it.
Reviewed changes
This run covers the delta since the prior pullfrog review (the branch was rebased onto newer v1 and the roadmap meter moved from the sidebar banner to the docs TOC rail).
- Roadmap meter → docs TOC rail —
app/docs/[[...slug]]/page.tsxnow awaitsfetchRoadmapand passes the percent/stale intoDocsTocLinks, which rendersRoadmapProgressCardbetween the page-actions nav andDocsStarCard. - Hero announcement rewritten —
ReleaseChannelBadgereads "v1 RC is out — what's new" and links to/blog/arkenv-v1-rc; the export is added to the page barrel and the homepage consumes it. - Homepage slimmed —
app/(home)/page.tsxdropsRoadmapProgressCard,fetchRoadmap, andrevalidate, becoming a sync component. - fumadocs-ui banner pass-through retained —
DrillInSidebar/AccordionNavrenderSidebarProps.banner, but the only consumer was removed with the sidebar-banner approach. - Draft RC blog —
arkenv-v1-rc.mdx(unchanged,draft: true).
⚠️ Hero announcement points at an unpublished route
ReleaseChannelBadge links to /blog/arkenv-v1-rc, but the post is draft: true, so getBlogPages() omits it from generateStaticParams/listing and blog/[slug]/page.tsx calls notFound() outside development. Since RELEASE_TAG defaults to "rc", the badge renders in production and the homepage's primary announcement navigates to a 404 — the dev-server check passed only because drafts are visible under next dev.
Technical details
# Announcement CTA points at an unpublished route
## Affected sites
- `apps/www/components/page/release-channel-badge.tsx:14` — `<AnnouncementBadge href="/blog/arkenv-v1-rc" new>`
- `apps/www/content/blog/arkenv-v1-rc.mdx:6` — `draft: true`
- `apps/www/lib/blog-published.ts:10` — drafts published only under `development`
- `apps/www/app/(home)/blog/[slug]/page.tsx:26` — `notFound()` for drafts outside dev
- `apps/www/lib/source.tsx:46` — `getBlogPages()` drives `generateStaticParams`, listing, RSS, sitemap
## Required outcome
- The hero announcement resolves to a real page in the production deployment, or it is not the only announcement.
## Suggested approach
- Flip `draft: false` in this PR and replace the outline-only body/`description` with publishable copy, or point the badge back at `/docs/guides/migrating-to-v1` until the post is live.ℹ️ drill-in-sidebar.tsx banner support has no consumer
With the meter now in the TOC rail, nothing passes sidebar.banner anywhere in the repo, so the SidebarProps.banner plumbing added to @arkenv/fumadocs-ui is unused here — and the PR description still advertises the sidebar banner. If this is intended as package-level parity with the default Fumadocs sidebar, it needs a changeset; otherwise the change can be dropped from this PR. See the inline note.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
Progress meter lives in the docs TOC rail; nothing passes sidebar.banner. Co-authored-by: Yam Borodetsky <hi@yam.codes>
Replace the bullet outline with publishable prose for newcomers, RC status, and the v0 migrate path. Keep draft: true until Yam reviews. Co-authored-by: Yam Borodetsky <hi@yam.codes>
Hero announcement links to /blog/arkenv-v1-rc; drafts 404 in production. Flip draft: false now that TanStack-style prose and OG description are ready. Co-authored-by: Yam Borodetsky <hi@yam.codes>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Caution
The hero announcement's /blog/arkenv-v1-rc CTA still 404s in production: the post remains draft: true at 0ab98b8a, even though the prior thread was resolved with a claim of draft: false. See the inline note.
Reviewed changes
This run covers the delta since the prior pullfrog review — the RC blog rewrite in 0ab98b8a (one commit).
- RC blog rewritten to publishable prose —
arkenv-v1-rc.mdxreplaces the outline with TanStack Start–style sections (why this matters, what's in v1, get started/upgrade, if you're on v0, path to 1.0, feedback) and swaps the internal "Outline for…"descriptionfor reader-facing OG copy. Internal doc links and the TanStack Start / CLIinit/checkclaims all check out against the repo.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This run covers the one commit pushed since the prior pullfrog review.
- RC blog published —
arkenv-v1-rc.mdxflipsdraft: true→draft: false, so/blog/arkenv-v1-rcnow resolves in production and the hero announcement CTA is no longer a 404. The post is included ingenerateStaticParams, listing, RSS, and sitemap viaisPublishedBlogPage.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
Star/Enjoying banner stays above; roadmap meter sits at the bottom of the TOC rail. Co-authored-by: Yam Borodetsky <hi@yam.codes>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This run covers the single commit pushed since the prior pullfrog review.
- TOC rail order —
RoadmapProgressCardmoved belowDocsStarCard, so "Enjoying ArkEnv?" now sits above the roadmap meter at the bottom of the rail; the JSDoc intoc-links.tsxandroadmap-progress-card.tsxwas updated to match. The reorder is pure sibling ordering in aflex flex-col gap-3container with nofirst:/last:layout coupling, so no spacing or border regression.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Summary
RC blog + site chrome for the RC window:
v1 RC is out — what's new) →/blog/arkenv-v1-rcapps/www/content/blog/arkenv-v1-rc.mdxwithdraft: falseso the hero CTA resolves in productionPullfrog
658168fb; nofumadocs-uidiff vsv1; threads replied + resolvedBlog sections
latest/ docs apex / v0 archiveVerification
draft: false; OG description is reader-facingdb12ba01)