Skip to content

fix: point Playground and example links at v1 - #1903

Merged
yamcodes merged 3 commits into
v1from
cursor/main-to-v1-pointers-da15
Sep 20, 2026
Merged

yamcodes merged 3 commits into
v1from
cursor/main-to-v1-pointers-da15

Conversation

@yamcodes

@yamcodes yamcodes commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Summary

Hardcoded stale branch URLs still sent living product surfaces to the v0 archive (main) or a deleted branch (dev). Production docs track Option A / v1.

Changes

  • Site Nav Playground → StackBlitz on v1 (apps/www/lib/stackblitz.ts)
  • Root + @arkenv/core READMEs, examples/README.md, community MDX, acknowledgements → v1 blob/tree links
  • CLI RegistryClient fetches examples/registry.json from v1 (patch changeset)
  • Docs “Edit this page” / example-card GitHub fallback branch: devv1
  • Footer MIT License: blob/devblob/v1 (Playwright + AGENTS.md learned fact)
  • @arkenv/core test badge: tests-badge.ymltest.yml (match root README; mirror was gated on deleted dev)
  • .changeset/config.json baseBranch: devv1
  • Playwright homepage assert Playground href includes /tree/v1/examples/stackblitz

Left intentional main mentions in branching/launch docs that describe the v0 archive.

Test plan

  • pnpm exec vitest run apps/www/lib/utils/github.test.ts
  • Confirm raw.githubusercontent.com/.../v1/examples/registry.json returns 200
  • Local www: Playground href + footer MIT License use v1
  • CI
Open in Web Open in Cursor 

Hardcoded main URLs still sent Playground, StackBlitz, and the CLI
example registry to the v0 archive. Retarget living product pointers to
v1 and default docs edit/example-card links to the same branch.

Co-authored-by: Yam Borodetsky <hi@yam.codes>
@changeset-bot

changeset-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4b242e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
arkenv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added docs Adds or changes documentation, or acts as documentation in and of itself arkenv Changes to the `arkenv` npm package. example Issues or Pull Requests concerning at least one ArkEnv example. (Found in the `examples/` directory) www Improvements or additions to arkenv.js.org tests This issue or PR is about adding, removing or changing tests labels Sep 20, 2026
@yamcodes yamcodes added the bug Something isn't working label Sep 20, 2026 — with Cursor
@pkg-pr-new

pkg-pr-new Bot commented Sep 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

@arkenv/agent-plugin

npm i https://pkg.pr.new/@arkenv/agent-plugin@1903

arkenv

npm i https://pkg.pr.new/arkenv@1903

@arkenv/build

npm i https://pkg.pr.new/@arkenv/build@1903

@arkenv/bun-plugin

npm i https://pkg.pr.new/@arkenv/bun-plugin@1903

@arkenv/core

npm i https://pkg.pr.new/@arkenv/core@1903

@arkenv/fumadocs-ui

npm i https://pkg.pr.new/@arkenv/fumadocs-ui@1903

@arkenv/nextjs

npm i https://pkg.pr.new/@arkenv/nextjs@1903

@arkenv/nuxt

npm i https://pkg.pr.new/@arkenv/nuxt@1903

@arkenv/rsbuild-plugin

npm i https://pkg.pr.new/@arkenv/rsbuild-plugin@1903

@arkenv/standard

npm i https://pkg.pr.new/@arkenv/standard@1903

@arkenv/tanstack-addon

npm i https://pkg.pr.new/@arkenv/tanstack-addon@1903

@arkenv/vite-plugin

npm i https://pkg.pr.new/@arkenv/vite-plugin@1903

commit: 4b242e1

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The repoint itself is correct, but this PR's whole purpose — getting living surfaces off stale branches — misses the footer's MIT License link, which still targets the deleted dev branch (404), and the packages/core badge now renders no status.

Reviewed changes

  • StackBlitz Playground → v1apps/www/lib/stackblitz.ts points the interactive example at tree/v1/examples/stackblitz; the Playwright homepage assertion was updated to match.
  • Docs "Edit this page" fallback → v1apps/www/lib/utils/github.ts falls back to v1 instead of dev, with apps/www/.env.example and github.test.ts updated in step.
  • CLI registry fetch → v1packages/arkenv/src/shared/clients/registry.client.ts loads examples/registry.json from v1 (verified 200), with a top-level patch changeset.
  • README / community / examples repoint — root and @arkenv/core READMEs, community.mdx, ACKNOWLEDGEMENTS.md, and examples/README.md now use v1 blob/tree URLs.

⚠️ The footer still links the MIT License at a branch that no longer exists

apps/www/components/site-footer.tsx:158 builds the footer license link from a hardcoded blob/dev/LICENSE. The dev branch is gone — the branches API returns 404 for it, and raw.githubusercontent.com/yamcodes/arkenv/dev/LICENSE 404s — so the "MIT License" link on every homepage and docs footer is broken. Because this PR exists to move living surfaces onto v1, this is the one stale branch pointer it should have caught, and the Playwright test currently pins the broken value instead of catching it.

Technical details
# Stale `dev` references after the v1 repoint

## Affected sites
- `apps/www/components/site-footer.tsx:158``${githubRepoUrl}/blob/dev/LICENSE`; `dev` is not a branch on `yamcodes/arkenv` (branches API → 404, raw file → 404). Renders a 404 from the live footer.
- `apps/playwright-www/tests/docs-toc.test.ts:149` — asserts the same `blob/dev/LICENSE` href, so the suite keeps passing while the link is dead.
- `AGENTS.md` — the "Learned Workspace Facts" note documents `blob/dev/LICENSE`; stale if the branch stays gone.
- `.github/workflows/tests-badge.yml:19` — mirror gated on `head_branch == 'dev'`, which can never match now (root cause of the `packages/core` badge showing "no status").

## Required outcome
- Branch pointers on living surfaces resolve against a branch that exists. Point the footer (and its assertion) at `v1`, or confirm `dev` is coming back.

## Open questions for the human
- `.changeset/config.json` still sets `baseBranch: "dev"`. Since this PR adds a changeset consumed by the `v1` release flow, is that base branch still valid for changesets, or does it need to become `v1`?

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Comment thread packages/core/README.md Outdated
Point the footer MIT License at v1 (dev is gone), align the core README
test badge with the root README's test.yml badge, and set changesets
baseBranch to v1 for the Option A release line.

Co-authored-by: Yam Borodetsky <hi@yam.codes>
@cursor

cursor Bot commented Sep 20, 2026

Copy link
Copy Markdown

Addressed Pullfrog review on 4b242e1:

  1. Footer MIT Licensesite-footer.tsx + Playwright docs-toc assertion + AGENTS.md learned fact now use blob/v1/LICENSE (dev 404s).
  2. Core README badge — src aligned with root README: test.yml/badge.svg?branch=v1 (no longer the dead tests-badge.yml mirror).
  3. Changeset baseBranch — set to v1 in .changeset/config.json. Option A release line already uses changeset-release/v1v1 (e.g. Version Packages (rc) #1885); dev is gone.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This run reviewed 4b242e1e (plus the two earlier commits for context) — the delta since the prior pullfrog review at 2573dd37. It finishes the stale-branch cleanup raised there:

  • Footer MIT License → v1apps/www/components/site-footer.tsx:158 now builds ${githubRepoUrl}/blob/v1/LICENSE, and the Playwright assertion at apps/playwright-www/tests/docs-toc.test.ts:149 was retargeted to match, so the suite no longer pins the dead link.
  • @arkenv/core badge fixedpackages/core/README.md:8 now points at test.yml/badge.svg?branch=v1 (matching the root README) instead of the dev-gated tests-badge.yml mirror.
  • Changesets base branch → v1.changeset/config.json baseBranch is now v1, the repo's actual default branch (confirmed via the API; dev 404s), answering the prior open question.
  • AGENTS.md learned fact updated — the footer license-link note now records blob/v1/LICENSE.

A repo-wide grep confirms no remaining yamcodes/arkenv/{blob,tree,edit}/dev|main pointers on living surfaces; the remaining main references are third-party links, test fixtures, or the intentional v0-archive docs.

Pullfrog  | View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

@yamcodes
yamcodes merged commit e6c8f78 into v1 Sep 20, 2026
21 checks passed
@yamcodes
yamcodes deleted the cursor/main-to-v1-pointers-da15 branch September 20, 2026 19:21
@arkenv-bot arkenv-bot Bot mentioned this pull request Sep 20, 2026
cursor Bot pushed a commit that referenced this pull request Sep 21, 2026
Bring in #1903 community.mdx v1 pointers (addresses Pullfrog note on
#1905) plus subsequent www commits on v1.

Co-authored-by: Yam Borodetsky <hi@yam.codes>
yamcodes added a commit that referenced this pull request Sep 21, 2026
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## Summary

Playgrounds were already on `@arkenv/core` / workspace `*`. Several
standalone examples were still on v0 or stale alpha pins.

- **`examples/stackblitz`**: switched from `import arkenv from "arkenv"`
(`^0.11.0`) to `import arkenv from "@arkenv/core"` (`1.0.0-rc.1`) with
modern `string.host` / `number.port` schema; runner is `tsx`
(StackBlitz-compatible ESM)
- **`with-zod` / `with-valibot`**: `@arkenv/standard` `^1.0.0-alpha.2` →
`1.0.0-rc.1`
- **`with-nextjs-zod` / `with-vite-react-zod`**: alpha plugin/standard
pins → `1.0.0-rc.1`, plus `legacy-peer-deps=true` `.npmrc`
- **Site + READMEs**: StackBlitz / example links use `tree/v1/...`;
merged latest `v1` so `community.mdx` contribution links match (#1903)

## Verification

Ran stackblitz / with-zod / with-valibot against published `1.0.0-rc.1`.
Pullfrog re-review approved after the `tsx` fix; community.mdx note
closed via merge from `v1`.

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-02b2d519-b294-47d7-a3de-2a769199527b?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-02b2d519-b294-47d7-a3de-2a769199527b&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arkenv Changes to the `arkenv` npm package. bug Something isn't working docs Adds or changes documentation, or acts as documentation in and of itself example Issues or Pull Requests concerning at least one ArkEnv example. (Found in the `examples/` directory) tests This issue or PR is about adding, removing or changing tests www Improvements or additions to arkenv.js.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants