fix: point Playground and example links at v1 - #1903
Conversation
Hardcoded main URLs still sent Playground, StackBlitz, and the CLI example registry to the v0 archive. Retarget living product pointers to v1 and default docs edit/example-card links to the same branch. Co-authored-by: Yam Borodetsky <hi@yam.codes>
🦋 Changeset detectedLatest commit: 4b242e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@arkenv/agent-plugin
arkenv
@arkenv/build
@arkenv/bun-plugin
@arkenv/core
@arkenv/fumadocs-ui
@arkenv/nextjs
@arkenv/nuxt
@arkenv/rsbuild-plugin
@arkenv/standard
@arkenv/tanstack-addon
@arkenv/vite-plugin
commit: |
There was a problem hiding this comment.
Important
The repoint itself is correct, but this PR's whole purpose — getting living surfaces off stale branches — misses the footer's MIT License link, which still targets the deleted dev branch (404), and the packages/core badge now renders no status.
Reviewed changes
- StackBlitz Playground →
v1—apps/www/lib/stackblitz.tspoints the interactive example attree/v1/examples/stackblitz; the Playwright homepage assertion was updated to match. - Docs "Edit this page" fallback →
v1—apps/www/lib/utils/github.tsfalls back tov1instead ofdev, withapps/www/.env.exampleandgithub.test.tsupdated in step. - CLI registry fetch →
v1—packages/arkenv/src/shared/clients/registry.client.tsloadsexamples/registry.jsonfromv1(verified 200), with a top-level patch changeset. - README / community / examples repoint — root and
@arkenv/coreREADMEs,community.mdx,ACKNOWLEDGEMENTS.md, andexamples/README.mdnow usev1blob/tree URLs.
⚠️ The footer still links the MIT License at a branch that no longer exists
apps/www/components/site-footer.tsx:158 builds the footer license link from a hardcoded blob/dev/LICENSE. The dev branch is gone — the branches API returns 404 for it, and raw.githubusercontent.com/yamcodes/arkenv/dev/LICENSE 404s — so the "MIT License" link on every homepage and docs footer is broken. Because this PR exists to move living surfaces onto v1, this is the one stale branch pointer it should have caught, and the Playwright test currently pins the broken value instead of catching it.
Technical details
# Stale `dev` references after the v1 repoint
## Affected sites
- `apps/www/components/site-footer.tsx:158` — `${githubRepoUrl}/blob/dev/LICENSE`; `dev` is not a branch on `yamcodes/arkenv` (branches API → 404, raw file → 404). Renders a 404 from the live footer.
- `apps/playwright-www/tests/docs-toc.test.ts:149` — asserts the same `blob/dev/LICENSE` href, so the suite keeps passing while the link is dead.
- `AGENTS.md` — the "Learned Workspace Facts" note documents `blob/dev/LICENSE`; stale if the branch stays gone.
- `.github/workflows/tests-badge.yml:19` — mirror gated on `head_branch == 'dev'`, which can never match now (root cause of the `packages/core` badge showing "no status").
## Required outcome
- Branch pointers on living surfaces resolve against a branch that exists. Point the footer (and its assertion) at `v1`, or confirm `dev` is coming back.
## Open questions for the human
- `.changeset/config.json` still sets `baseBranch: "dev"`. Since this PR adds a changeset consumed by the `v1` release flow, is that base branch still valid for changesets, or does it need to become `v1`?DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
Point the footer MIT License at v1 (dev is gone), align the core README test badge with the root README's test.yml badge, and set changesets baseBranch to v1 for the Option A release line. Co-authored-by: Yam Borodetsky <hi@yam.codes>
|
Addressed Pullfrog review on 4b242e1:
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This run reviewed 4b242e1e (plus the two earlier commits for context) — the delta since the prior pullfrog review at 2573dd37. It finishes the stale-branch cleanup raised there:
- Footer MIT License →
v1—apps/www/components/site-footer.tsx:158now builds${githubRepoUrl}/blob/v1/LICENSE, and the Playwright assertion atapps/playwright-www/tests/docs-toc.test.ts:149was retargeted to match, so the suite no longer pins the dead link. @arkenv/corebadge fixed —packages/core/README.md:8now points attest.yml/badge.svg?branch=v1(matching the root README) instead of thedev-gatedtests-badge.ymlmirror.- Changesets base branch →
v1—.changeset/config.jsonbaseBranchis nowv1, the repo's actual default branch (confirmed via the API;dev404s), answering the prior open question. AGENTS.mdlearned fact updated — the footer license-link note now recordsblob/v1/LICENSE.
A repo-wide grep confirms no remaining yamcodes/arkenv/{blob,tree,edit}/dev|main pointers on living surfaces; the remaining main references are third-party links, test fixtures, or the intentional v0-archive docs.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> ## Summary Playgrounds were already on `@arkenv/core` / workspace `*`. Several standalone examples were still on v0 or stale alpha pins. - **`examples/stackblitz`**: switched from `import arkenv from "arkenv"` (`^0.11.0`) to `import arkenv from "@arkenv/core"` (`1.0.0-rc.1`) with modern `string.host` / `number.port` schema; runner is `tsx` (StackBlitz-compatible ESM) - **`with-zod` / `with-valibot`**: `@arkenv/standard` `^1.0.0-alpha.2` → `1.0.0-rc.1` - **`with-nextjs-zod` / `with-vite-react-zod`**: alpha plugin/standard pins → `1.0.0-rc.1`, plus `legacy-peer-deps=true` `.npmrc` - **Site + READMEs**: StackBlitz / example links use `tree/v1/...`; merged latest `v1` so `community.mdx` contribution links match (#1903) ## Verification Ran stackblitz / with-zod / with-valibot against published `1.0.0-rc.1`. Pullfrog re-review approved after the `tsx` fix; community.mdx note closed via merge from `v1`. <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-02b2d519-b294-47d7-a3de-2a769199527b?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-02b2d519-b294-47d7-a3de-2a769199527b&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Summary
Hardcoded stale branch URLs still sent living product surfaces to the v0 archive (
main) or a deleted branch (dev). Production docs track Option A /v1.Changes
v1(apps/www/lib/stackblitz.ts)@arkenv/coreREADMEs,examples/README.md, community MDX, acknowledgements →v1blob/tree linksRegistryClientfetchesexamples/registry.jsonfromv1(patch changeset)dev→v1blob/dev→blob/v1(Playwright +AGENTS.mdlearned fact)@arkenv/coretest badge:tests-badge.yml→test.yml(match root README; mirror was gated on deleteddev).changeset/config.jsonbaseBranch:dev→v1/tree/v1/examples/stackblitzLeft intentional
mainmentions in branching/launch docs that describe the v0 archive.Test plan
pnpm exec vitest run apps/www/lib/utils/github.test.tsraw.githubusercontent.com/.../v1/examples/registry.jsonreturns 200www: Playground href + footer MIT License usev1