-
Notifications
You must be signed in to change notification settings - Fork 35
refactor: simplify checkout URL handling and update Dodo mode configuration: #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,7 +85,7 @@ FIRECRAWL_API_KEY="" | |
| DODO_PAYMENTS_API_KEY="" | ||
| DODO_PAYMENTS_WEBHOOK_KEY="" | ||
| # ⚪ "test" to use test-mode product IDs in the seed; omit for live. | ||
| DODO_MODE="test" | ||
| DODO_MODE="" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win Keep the example in test mode or make live mode explicit.
🧰 Tools🪛 dotenv-linter (4.0.0)[warning] 88-88: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 88-88: [UnorderedKey] The DODO_MODE key should go before the DODO_PAYMENTS_API_KEY key (UnorderedKey) 🤖 Prompt for AI Agents |
||
| # Where Dodo redirects after checkout (used by the checkout route) | ||
| # Test: set to localhost or ngrok URL | ||
| # Live: https://supercode-terminal.vercel.app/studio?success=true | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Close the checkout dialog after opening the payment link.
The new-tab path leaves
confirmingPlanset. The dialog remains open in the current tab, so the user can click Pay now again and start multiple checkout attempts. Clear the state afterwindow.openreturns.Proposed fix
window.open(url, "_blank", "noopener,noreferrer") + setConfirmingPlan(null)📝 Committable suggestion
🤖 Prompt for AI Agents