Odbc static cursors by Shfdis · Pull Request #660 · ydb-platform/ydb-cpp-sdk

Shfdis · 2026-08-21T15:02:03Z

No description provided.

github-actions · 2026-08-21T15:45:28Z

ODBC integration report

✨ Open the interactive Allure report · 📦 Download the report bundle

Commit: 2b4b30149135cc3db9349a7a34f93af39b96f60c; result: success; updated by each run.

Shfdis · 2026-08-24T11:19:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17df722cad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

robot-vibe-db

AI Review Summary

Verdict: ✅ No critical issues found

The cursor window implementation correctly follows the ODBC spec for all fetch orientations (NEXT, PRIOR, FIRST, LAST, ABSOLUTE, RELATIVE), including the overlapped-start SQLSTATE 01S06. The NegativeMagnitude helper correctly handles SQLLEN_MIN without signed overflow. The PrimitiveText refactoring in convert.cpp is safe — both old and new paths ultimately call WriteText for string types, so the only change is avoiding a string copy. The FillBoundColumns error-handling change (removing the LastFetchRc_ == SQL_SUCCESS guard) is an improvement: the old code could leave LastConvertSqlState unconsumed when a second column failed after the first, leaking state to the next GetData call.

Critical issues

No critical issues found.

Other findings

Minor | Medium: TStaticCursor::EnsureRow throws generic std::runtime_error through the ODBC API boundary — odbc/src/utils/cursor.cpp:133
Minor | Low: TForwardCursor bypasses the inherited TCursorWindow entirely (overrides Fetch/GetRowNumber without delegation), leaving the base-class window at totalRows=0 — odbc/src/utils/cursor.cpp:55
Nit | Low: PrimitiveText returns std::string_view into parser-owned state; lifetime is correct in all current call sites but the contract is implicit — odbc/src/utils/convert.cpp:542

This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

robot-vibe-db · 2026-08-24T11:35:30Z

Full analysis log

Analysis performed by claude, claude-opus-4-6.

Shfdis · 2026-08-24T11:46:41Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70fa75ebb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

robot-vibe-db

AI Review Summary

Verdict: ✅ No critical issues found

Critical issues

No critical issues found.

Other findings

Nit | High: SQLSTATE inconsistency — setCursorType uses HY011 but SQL_ATTR_CONCURRENCY uses 24000 for the same "cursor is open" guard — odbc/src/statement.cpp:875 / odbc/src/statement.cpp:910

This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

robot-vibe-db · 2026-08-24T11:58:04Z

Full analysis log

Analysis performed by claude, claude-opus-4-6.

Shfdis · 2026-08-24T12:43:57Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca764629e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Shfdis · 2026-08-25T09:49:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b4b301491

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Artem Ermoshkin added 2 commits August 21, 2026 16:44

Implement static ODBC cursors

197fade

Simplify static ODBC cursor storage

c243f8a

Shfdis added the ODBC full matrix label Aug 21, 2026

Fix ODBC CI classification and cursor test build

df7b125

github-actions Bot added a commit that referenced this pull request Aug 21, 2026

Publish ODBC report for PR #660

49c88ae

Fix Qt static cursor navigation

d855137

github-actions Bot added a commit that referenced this pull request Aug 21, 2026

Publish ODBC report for PR #660

570e128

Classify remaining Qt limitations

3365414

github-actions Bot added a commit that referenced this pull request Aug 24, 2026

Publish ODBC report for PR #660

f4c7322

Fix qt untyped null to null conversions

8dce4a2

github-actions Bot added a commit that referenced this pull request Aug 24, 2026

Publish ODBC report for PR #660

af5a94a

simplify rowset resolving

17df722

github-actions Bot added a commit that referenced this pull request Aug 24, 2026

Publish ODBC report for PR #660

482cc53

Shfdis added the need_ai_review label Aug 24, 2026

robot-vibe-db Bot added ai_review_in_process and removed need_ai_review labels Aug 24, 2026

chatgpt-codex-connector Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread odbc/src/utils/cursor.cpp Outdated

Comment thread odbc/src/metadata.cpp

github-actions Bot added a commit that referenced this pull request Aug 24, 2026

Publish ODBC report for PR #660

70671a5

robot-vibe-db Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread odbc/src/utils/cursor.cpp Outdated

Comment thread odbc/src/utils/cursor.cpp

Comment thread odbc/src/utils/convert.cpp

robot-vibe-db Bot added ai_reviewed and removed ai_review_in_process labels Aug 24, 2026

fix review issues

d8f1f5f

github-actions Bot added a commit that referenced this pull request Aug 24, 2026

Publish ODBC report for PR #660

4b139e0

more detailed errors

70fa75e

github-actions Bot added a commit that referenced this pull request Aug 24, 2026

Publish ODBC report for PR #660

fcba8df

Shfdis added need_ai_review and removed ai_reviewed labels Aug 24, 2026

robot-vibe-db Bot added ai_review_in_process and removed need_ai_review labels Aug 24, 2026

chatgpt-codex-connector Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread odbc/src/statement.cpp

Comment thread odbc/src/statement.cpp Outdated

github-actions Bot added a commit that referenced this pull request Aug 24, 2026

Publish ODBC report for PR #660

891b398

robot-vibe-db Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread odbc/src/statement.cpp

robot-vibe-db Bot added ai_reviewed and removed ai_review_in_process labels Aug 24, 2026

fix cursor state handling

ca76462

github-actions Bot added a commit that referenced this pull request Aug 24, 2026

Publish ODBC report for PR #660

973a875

github-actions Bot added a commit that referenced this pull request Aug 24, 2026

Publish ODBC report for PR #660

1861c2d

chatgpt-codex-connector Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread odbc/src/utils/cursor.cpp Outdated

Cap forward cursor rowset reservation

2b4b301

github-actions Bot added a commit that referenced this pull request Aug 24, 2026

Publish ODBC report for PR #660

2a2df60

chatgpt-codex-connector Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread odbc/src/utils/cursor.cpp

Uh oh!

Conversation

Shfdis commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ODBC integration report

Uh oh!

Shfdis commented Aug 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

robot-vibe-db Bot left a comment

Choose a reason for hiding this comment

AI Review Summary

Critical issues

Other findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robot-vibe-db Bot commented Aug 24, 2026

Uh oh!

Shfdis commented Aug 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

robot-vibe-db Bot left a comment

Choose a reason for hiding this comment

AI Review Summary

Critical issues

Other findings

Uh oh!

Uh oh!

robot-vibe-db Bot commented Aug 24, 2026

Uh oh!

Shfdis commented Aug 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Shfdis commented Aug 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Aug 21, 2026 •

edited

Loading