Skip to content

fix standalone SDK dependency discovery - #662

Merged
Shfdis merged 1 commit into
ydb-platform:mainfrom
Shfdis:fix/userver-integration
Aug 26, 2026
Merged

fix standalone SDK dependency discovery#662
Shfdis merged 1 commit into
ydb-platform:mainfrom
Shfdis:fix/userver-integration

Conversation

@Shfdis

@Shfdis Shfdis commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Fix the installed standalone SDK package so it can be consumed by userver and other embedding CMake projects.

  • reuse existing Protobuf, gRPC, and Abseil targets when provided by the parent project
  • fall back to grpc++ pkg-config metadata when the distro gRPC package has no CMake config
  • declare the missing Abseil and pkg-config Debian dependencies
  • cover predefined RPC targets and the pkg-config fallback in Debian package tests

@Shfdis Shfdis added the SLO label Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.04%. Comparing base (cf7308e) to head (fa886ce).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
+ Coverage   54.99%   55.04%   +0.04%     
==========================================
  Files         280      280              
  Lines       32702    32702              
==========================================
+ Hits        17986    18001      +15     
+ Misses      14716    14701      -15     
Flag Coverage Δ
sdk 55.04% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

🌋 SLO Test Results

🟡 2 workload(s) tested — 1 workload(s) exceeded warning thresholds

Commit: b6c114d · View run

Workload Thresholds Duration Report
cpp-key-value-userver 🟢 OK 10m 2s 📄 Report
cpp-key-value 🟡 Warning 10m 4s 📄 Report

Threshold violations:

cpp-key-value:

  • read_retry_attempts: Value 0.05 > warning max 0
  • write_retry_attempts: ▲ 27.2% (≥ 20% warn)

Generated by ydb-slo-action

@Shfdis
Shfdis merged commit 802c146 into ydb-platform:main Aug 26, 2026
27 checks passed
@Shfdis
Shfdis deleted the fix/userver-integration branch August 26, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants