GPU trace-gen (part 2): 7 more device-resident fills + preprocessed-table GPU LDE#811
Draft
ColoCarletti wants to merge 5 commits into
Draft
GPU trace-gen (part 2): 7 more device-resident fills + preprocessed-table GPU LDE#811ColoCarletti wants to merge 5 commits into
ColoCarletti wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on part 1 (#803). Extends the device-resident trace-gen seam to the rest of the per-op tables and moves the remaining tables' LDE onto the GPU.
What this PR does
7 more table fills go device-resident (built directly in VRAM, feeding the LDE/commit with no host upload, same seam as part 1):
EQ, BYTEWISE, MUL, DVRM (ALU) · BRANCH · CPU32 · MEMW (general)
With part 1 this puts the entire per-op arithmetic / control / memory family on GPU (14 tables total).
Preprocessed tables now LDE on GPU. The 6 lookup tables that commit two Merkle trees (BITWISE, DECODE, PAGE, GLOBAL_MEMORY, REGISTER, KECCAK_RC) can't use the device full-column Merkle, so their fill + Merkle stay on host, but the LDE (the dominant cost) now runs on GPU every proof via a new no-Merkle device LDE path.
Net: essentially all main-trace fill + LDE now runs on GPU.
Also: dedupes the per-table dispatchers into one
gpu_build_tables<T>helper, and moves the GPU fill-parity tests out of production code intoprover/src/tests/gpu_fill_tests.rs.Correctness
generate_*_trace— 14 tests, all green on RTX 5090.prove → verifygreen, incl. the preprocessed GPU-LDE (proofs with BITWISE/DECODE LDE'd on device still verify; the static-root assert is unchanged and the opening path is untouched).Performance
What's left for future PRs