Stream proof serialization into the writer#819
Draft
jotabulacios wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream proof serialization into the output writer
Motivation
When writing a proof to disk, the CLI serialized the whole proof into an in-memory
Vec<u8>and then wrote that buffer out. This holds two full copies of the proof in RAMat once — the proof struct plus its serialized bytes — roughly 2× the proof size at
write time.
For monolithic proofs the buffer is small, but continuation bundles grow with the number
of epochs, so for large blocks this duplicate buffer is several GB and becomes the process
memory peak — at large enough sizes it can OOM. It is a memory inefficiency, not a
correctness issue: the written proof was always valid.
Change
Replace
bincode::serialize(&x)+writer.write_all(&bytes)withbincode::serialize_into(&mut writer, &x)+writer.flush()in both proof-writing paths(
cmd_proveandcmd_prove_continuation). The encoding streams straight into theBufWriter, so only the proof itself — not a second serialized copy — is resident duringthe write. Output is byte-identical; existing proofs and verification are unaffected.
Impact (measured)
100-transfer ethrex block,
--epoch-size-log2 19, plain continuationsmulti-GB
Vec).