Repository navigation
Get CI running again - #5
Merged
Merged
Conversation
CI has been red since Quickdraw dropped the `-t` option and the top-level `test` DSL, and Bundler 4 removed `bundle install --without`. - Run `bundle exec qt` without `-t`, and skip the development group with BUNDLE_WITHOUT instead of `--without` - Wrap the tests in Quickdraw::Test subclasses (whitespace-only apart from the class lines; heredoc contents are unchanged) - Drop `assert_equal_ruby`, which no longer exists; the strict `assert_equal` beside it already covers it - Fix the two RuboCop offenses on main - Add Ruby 4.0 to the matrix and bump actions/checkout to v7, as in Phlex Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019moK5994ZrLtnK6Qu87GUg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joel · project thread
Before: every CI job on
mainfails. The test jobs die before loading a test (bundle install --withoutis gone in Bundler 4,qt -t 1is no longer a Quickdraw option, and the top-leveltestDSL resolves toKernel#test), and RuboCop reports two offenses.After: the suite runs on every Ruby in the matrix and RuboCop is clean. CI-only: no change to Refract's behaviour.
How:
bundle exec qtwith no-t; skip the development group withBUNDLE_WITHOUTrather than--without; add Ruby 4.0 and bumpactions/checkoutto v7, matching Phlex.test/refract.test.rbandtest/corpus.test.rbinQuickdraw::Testsubclasses. Whitespace-only apart from the class lines (git diff -wis 4 lines); I checked with Prism that all 911 string literals, heredocs included, are byte-identical.assert_equal_ruby, which no longer exists; the strictassert_equalbeside it already implies it.formatter.rb:16,refract.gemspec:24).Locally: 634 passed, 0 failed on Ruby 3.2.6 and 3.3.6; RuboCop 163 files, no offenses.
This covers the CI part of #3 only; its formatter and TruffleRuby fixes are separate behaviour changes and are left for that PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_019moK5994ZrLtnK6Qu87GUg
Generated by Claude Code