Repository navigation
Conversation
yoohaemin
force-pushed
the
proof-construction
branch
from
October 10, 2026 02:14
a7c6ede to
0d6e37b
Compare
yoohaemin
force-pushed
the
proof-construction
branch
from
October 10, 2026 07:22
0d6e37b to
39faf15
Compare
yoohaemin
force-pushed
the
proof-construction
branch
from
October 10, 2026 08:04
39faf15 to
c0368b9
Compare
yoohaemin
marked this pull request as ready for review
October 10, 2026 08:04
There was a problem hiding this comment.
🟡 Changes recommended
The unchanged Kyo syntax can no longer resolve proofs for composed relations.
1 open finding
What changed in this PR
Binds relation values during proof construction and caches completed interpreters for reification.
Changes:
- Converts proof derivation to relation-bound conversions.
- Updates Fetch, ZQuery, and generator syntax.
- Adds construction/caching regression coverage and documentation.
| File | Description |
|---|---|
zquery/src/test/scala/decrel/reify/ZQueryProofConstructionSpec.scala |
Tests eager proof binding and reuse. |
zquery/src/main/scala-3/decrel/reify/zquerySyntax.scala |
Caches bound proofs in Scala 3 syntax. |
zquery/src/main/scala-2.13/decrel/reify/zquerySyntax.scala |
Caches bound proofs in Scala 2 syntax. |
zquery-next/src/main/scala/decrel/reify/zqueryNextSyntax.scala |
Applies proof conversions to relations. |
ziotest/src/main/scala/decrel/ziotest/gen.scala |
Updates generator expansion. |
scalacheck/src/main/scala/decrel/scalacheck/gen.scala |
Updates generator expansion. |
mdoc/docs/guide/defining-relations.md |
Documents proof construction. |
fetch/src/main/scala/decrel/reify/fetch.scala |
Binds and caches Fetch proofs. |
core/src/test/scala/decrel/reify/ProofConstructionSpec.scala |
Covers binding, composition, and caching. |
core/src/main/scala/decrel/reify/monofunctor/proof.scala |
Refactors monofunctor proof derivation. |
core/src/main/scala/decrel/reify/bifunctor/proof.scala |
Refactors error-aware proof derivation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind actual relation values during implicit syntax conversion, then expose the completed interpreter through a cached, parameterless
Proof.reify. Composition constructs proofs from the actual child nodes. ZQuery and Fetch syntax retain the bound proof before their methods run, and existing fixed declaration proofs remain usable through a low-priority adapter.