[yt314]

The problem

A note marked גלוי לתלמיד is always visible to the parent too. The server enforces it, and rightly — a parent should not be kept from what was written about their child.

The lesson-completion dialog never said so. Two independent checkboxes: tick גלוי לתלמיד, leave גלוי להורה clear, save. The note is stored visible to both, and the teacher has just written something she believes only the student will read.

Proven against the running app:

what the teacher ticked : visibleToStudent=true, visibleToParent=false
what the server stored  : visibleToStudent=true, visibleToParent=true
the parent can read it  : true

The note dialog on the student card already explains the rule in a line under the boxes. So the app had decided how to handle this — the screen used after every single lesson was the one that missed it.

This is the screen where most notes get written: it is inside סיום שיעור, right after the lesson.

The change

Ticking גלוי לתלמיד now ticks גלוי להורה as well, in both dialogs, so the boxes show what will actually be stored instead of a promise the save will break. The completion dialog gets the same explanatory line the other one has.

Unticking גלוי לתלמיד leaves the parent box where it is — a note for the parent only is a real thing to want, and the rule only runs one way.

Why not change the rule instead

The rule is the right one and is deliberate; it is in the server on both POST and PUT, with four tests covering it (create, update, and both read paths). Nothing about it changes here. What changes is that the screen stops disagreeing with it.

Verification

Driven in a browser at 1280px, both dialogs:

completion dialog   BEFORE: student=false  parent=false
                    AFTER ticking גלוי לתלמיד: student=true  parent=true
                    …הערה שמסומנת "גלוי לתלמיד" גלויה אוטומטית גם להורה

student-card dialog BEFORE: student=false  parent=false
                    AFTER:  student=true   parent=true

Nothing was saved (both dialogs cancelled), and the probe note used to prove the original behaviour was deleted; the demo data is untouched. No JS errors.

24 frontend tests pass. Frontend only; no API change.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
talmidon	Ready	Preview	Sep 17, 2026 4:24pm UTC