Say what failed: no network, and a session that expired mid-work

[yt314]

Two cases where the system knew what had happened — and did not say so.

1. No network

A teacher marks a finished lesson from her phone and the wifi drops. What she saw until now:

AFTER SAVE WITH NO NETWORK: … העדכון נכשל …
MENTIONS CONNECTION? NO

"The update failed" leaves open exactly the question that matters: was the change saved or not? When the request never reached the server at all, Angular returns status 0 with no response body, and that can be said outright:

BLOCKED: POST /api/lessons/…/complete
TOAST: "שגיאה  אין חיבור לשרת. בדקי את החיבור לאינטרנט ונסי שוב."

That both explains what happened and says what to do about it. The fix sits in extract-error-message.ts — the function every screen already routes its errors through — so the whole app gets it at once.

2. The session expired mid-work

A teacher inside the payments screen, token expired, refresh failed:

SHE IS ON  : http://localhost:4200/app/payments
LANDED ON  : http://localhost:4200/login
ANY REASON GIVEN? NO

A blank login form, no reason, no way back. The interesting part: the capability already existed in the code. auth.guard.ts adds returnUrl, idle-logout.service.ts adds timeout=1 and the login screen explains "you were logged out for inactivity". Only auth.interceptor.ts — the one path of the three that fires while she is working — used neither.

After the fix:

LANDED ON  : http://localhost:4200/login?expired=1&returnUrl=%2Fapp%2Fpayments
SCREEN SAYS: … ההתחברות פגה. יש להתחבר שוב — ונחזיר אותך למקום שבו היית. …
ANY REASON GIVEN? yes

A deliberate decision: the route guard stays silent

auth.guard.ts does not get expired=1, on purpose. It also fires on a first visit to a bookmark or a shared link, and there "your session expired" would simply be untrue. Only the interceptor path guarantees there was a session and that it ended.

Testing

• npx ng build — clean.
• npx vitest run — 30 passing, including a new spec for extract-error-message covering status 0, a 409 carrying a real message (so it is not mistaken for a lost connection), a controller message, an errors array, a ProblemDetails errors dictionary, and the fallback. (app.spec.ts fails on main too — unrelated.)
• Both scenarios were reproduced in the browser before and after, using page.route to drop the network and to return 401.

Demo data untouched — 4 teachers, 3 students.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
talmidon	Ready	Preview	Sep 18, 2026 7:36am UTC