Repository navigation
refactor(query): share search and Git decoding, reduce test fixture duplication - #1238
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Search option construction and Git result framing were maintained twice, while common Runner and handoff test setup repeated large capability and registration literals. This makes small policy or fixture changes require synchronized edits without adding coverage.
Changes
No public result/schema shape, production authorization boundary or future Agent Loop primitive is removed.
Measured reduction
Measured against
66dc9703c5714901b083f000a1b6b8d40ef7785c, after cargo fmt, including new helpers:The same MSI
cloc 0.6.2used for the repository reports changed-file Rust code 22,695 -> 21,961, a 734-line reduction. Its code counter differs from physical diff lines. Most of this PR's reduction is reusable test setup, rather than removed production features.Validation
On MSI Windows, reusing
E:\git\webcodex\target:runner-real-process-testscases for search modes/fallback and directory globs/bounds: 2 passed.cargo fmt --all -- --checkandgit diff --check.The POSIX shell-metacharacter test and Unix producer-cleanup tests are platform gated and were not executed on MSI. They remain available to Linux CI. This PR does not claim full-workspace or cross-platform process validation.