Repository navigation
refactor(communication): share request payloads across tool and Console routes - #1239
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Eleven Communication operations declared the same request fields independently in ToolCall and Console. Dispatch then unpacked and forwarded those fields again, leaving several places to maintain each input change.
Changes
control_def/runner_project_read_defconstructors for 18 matching tool declarations. No new constructor or schema framework.Reduction
Compared with
7b35aafb0603fb445f9d3f86ab05b2dcf977a1db, including the new shared request declarations:The test increase comes from explicit request-struct construction at existing call sites, not added scenarios. MSI's installed Rust
cloc 0.6.2reports 28,757 → 28,482 code lines in changed files, a net reduction of 275. Physical diff counts include comments and blank lines; production/test attribution follows dedicated test paths and Rust test scopes.Validation
Performed on Windows MSI in the existing
E:\git\webcodexcheckout and target cache:ToolCall::from_tool_nameand raw serde: accepted/rejected cases and normalized wire values unchanged, including omitted/null/empty fields, wrong types, missing required fields and unknown fields.cargo fmt --all -- --checkandgit diff --cached --checkpassed.No full workspace test suite, cross-platform process tests or production load test was run; this change does not alter platform process management. Temporary contract exporters were removed before commit.