feat(zsh): govern plugin standard reviews - #501
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.
Suppressed comments (2)
scripts/test_validate_agent_policy.py:1484
- This test invokes
zshviasubprocess.run(...)but does not handle environments wherezshis not installed. That makes the unit test suite fail withFileNotFoundErrorfor local contributors (even though CI installs Zsh in the workflow). Add an explicit availability check and skip the test when Zsh is missing.
def test_new_zsh_plugin_scaffold_owns_only_its_fpath_change(self) -> None:
template = (
PUBLIC_ROOT
/ ".github/skills/new-zsh-plugin/templates/plugin.plugin.zsh"
).read_text()
.github/skills/new-zsh-plugin/templates/plugin.plugin.zsh:10
- The comment says
PMSPEC=fmeans the manager ownsfpathsetup, but the code correctly treatsPMSPECas a capability string (it checks for*f*). Update the comment to match the actual behavior so it doesn't mislead future readers.
# Optional manager capability: PMSPEC=f means the manager owns fpath setup.
# https://wiki.zshell.dev/community/zsh_plugin_standard#functions-directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issues: write, and idempotent UTC half-year issue creationRelated to #493.
Related to z-shell/wiki#840.
Verification
python3 scripts/validate-agent-policy.pypython3 -m unittest scripts/test_validate_agent_policy.py -v(72 tests)trunk check --no-fix --filter=-gitleakson changed Markdown/instruction surfaces and the instruction workflow (no new issues).github/workflows/agent-instructions.ymlwith Ruby YAMLfpathstategit diff --checkAgent handoff