Skip to content

feat(zsh): govern plugin standard reviews - #501

Merged
ss-o merged 2 commits into
mainfrom
ss-o-govern-plugin-standard
Aug 15, 2026
Merged

feat(zsh): govern plugin standard reviews#501
ss-o merged 2 commits into
mainfrom
ss-o-govern-plugin-standard

Conversation

@ss-o

@ss-o ss-o commented Aug 15, 2026

Copy link
Copy Markdown
Member

Summary

  • establish the wiki Zsh Plugin Standard as the canonical public plugin-authoring guidance while keeping official Zsh documentation authoritative for shell semantics
  • add required task/path routing, scoped instructions, and consistent plugin reviewer, README, scaffold, pattern, and bootstrap guidance
  • define the maintainer-authorized semiannual wiki review procedure, including deterministic evidence, bounded issues: write, and idempotent UTC half-year issue creation

Related to #493.
Related to z-shell/wiki#840.

Verification

  • python3 scripts/validate-agent-policy.py
  • python3 -m unittest scripts/test_validate_agent_policy.py -v (72 tests)
  • trunk check --no-fix --filter=-gitleaks on changed Markdown/instruction surfaces and the instruction workflow (no new issues)
  • parsed .github/workflows/agent-instructions.yml with Ruby YAML
  • scaffold source/unload regression coverage for manager-owned, plugin-owned, and repeated-source fpath state
  • git diff --check

Agent handoff

@ss-o
ss-o requested a review from a team as a code owner August 15, 2026 11:38
Copilot AI lite review requested due to automatic review settings August 15, 2026 11:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 15, 2026 11:44
@ss-o
ss-o enabled auto-merge (squash) August 15, 2026 11:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

Suppressed comments (2)

scripts/test_validate_agent_policy.py:1484

  • This test invokes zsh via subprocess.run(...) but does not handle environments where zsh is not installed. That makes the unit test suite fail with FileNotFoundError for local contributors (even though CI installs Zsh in the workflow). Add an explicit availability check and skip the test when Zsh is missing.
    def test_new_zsh_plugin_scaffold_owns_only_its_fpath_change(self) -> None:
        template = (
            PUBLIC_ROOT
            / ".github/skills/new-zsh-plugin/templates/plugin.plugin.zsh"
        ).read_text()

.github/skills/new-zsh-plugin/templates/plugin.plugin.zsh:10

  • The comment says PMSPEC=f means the manager owns fpath setup, but the code correctly treats PMSPEC as a capability string (it checks for *f*). Update the comment to match the actual behavior so it doesn't mislead future readers.
# Optional manager capability: PMSPEC=f means the manager owns fpath setup.
# https://wiki.zshell.dev/community/zsh_plugin_standard#functions-directory

@ss-o
ss-o disabled auto-merge August 15, 2026 11:53
@ss-o
ss-o merged commit 6f9a6ba into main Aug 15, 2026
8 checks passed
@ss-o
ss-o deleted the ss-o-govern-plugin-standard branch August 15, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants