Signal configuration and do not set default in SW - #370
Merged
Conversation
Member
|
New Issues (2)
Checkmarx found the following issues in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
thc202
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds a way to detect when the extension has been auto-configured and prevents the background service worker from overwriting an existing configuration by removing the install-time default writes.
Changes:
- Add a new localStorage key constant to signal that auto-configuration completed.
- Update the content script configuration flow to await sync-storage writes and set a “configured” flag.
- Remove on-install default
zapurl/zapkeywrites from the background script and document the fix in the changelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| source/utils/constants.ts | Adds a constant for the “configured” signal key. |
| source/ContentScript/index.ts | Makes configuration async, awaits sync writes, and sets a configured flag. |
| source/Background/index.ts | Removes install-time sync-storage defaults to avoid resetting configuration. |
| CHANGELOG.md | Adds a 0.2.2 entry describing the fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
thc202
marked this pull request as ready for review
August 13, 2026 15:32
psiinon
approved these changes
Aug 13, 2026
Allow to programmatically tell if the browser extension was configured and do not set defaults in the ServiceWorker which would reset the configuration. Signed-off-by: thc202 <thc202@gmail.com>
kingthorin
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to programmatically tell if the browser extension was configured and do not set defaults in the ServiceWorker which would reset the configuration.