Skip to content

Convert rst double-backtick docstring markup to markdown - #4193

Merged
d-v-b merged 2 commits into
zarr-developers:mainfrom
jhamman:feature/markdown-docstrings
Aug 3, 2026
Merged

Convert rst double-backtick docstring markup to markdown#4193
d-v-b merged 2 commits into
zarr-developers:mainfrom
jhamman:feature/markdown-docstrings

Conversation

@jhamman

@jhamman jhamman commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary

Docstring-only change: replace code (reStructuredText) with code (Markdown) in zarr.api.asynchronous, zarr.registry, and zarr.storage._common, matching the repo's mkdocs-based docs.

For reviewers

@d-v-b - this was uncovered when you asked me to go rst->markdown in #4187.

Author attestation

  • I am a human, these are my changes, and I have reviewed and understood every change and can explain why each is correct.

TODO

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Comment thread changes/9999.doc.md Outdated
@@ -0,0 +1,3 @@
Converted remaining reStructuredText-style double-backtick markup to Markdown
single backticks in the docstrings of `zarr.api.asynchronous`, `zarr.registry`,
and `zarr.storage._common`. No functional changes.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to update PR number

@d-v-b

d-v-b commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

thanks joe!

@d-v-b

d-v-b commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

i think you need to apply the symmetric transformation to the routines in synchronous.py.

@jhamman
jhamman force-pushed the feature/markdown-docstrings branch from 626e63c to 2509d00 Compare July 30, 2026 04:51
Docstring-only change: replace ``code`` (reStructuredText) with `code`
(Markdown) in zarr.api.asynchronous, zarr.registry, and
zarr.storage._common, matching the repo's mkdocs-based docs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jhamman
jhamman force-pushed the feature/markdown-docstrings branch from 2509d00 to b148726 Compare July 30, 2026 04:51
@d-v-b
d-v-b enabled auto-merge (squash) August 3, 2026 17:01
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.99%. Comparing base (24f9ad1) to head (d02a6e1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4193   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files          91       91           
  Lines       12795    12795           
=======================================
  Hits        12027    12027           
  Misses        768      768           
Files with missing lines Coverage Δ
src/zarr/api/asynchronous.py 96.32% <ø> (ø)
src/zarr/api/synchronous.py 92.95% <ø> (ø)
src/zarr/core/array.py 97.85% <ø> (ø)
src/zarr/registry.py 89.47% <ø> (ø)
src/zarr/storage/_common.py 92.53% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b
d-v-b merged commit 976be69 into zarr-developers:main Aug 3, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants