Skip to content

Fix assistant walkthroughs and add opt-in chat history search - #318

Merged
zerodrift merged 2 commits into
masterfrom
codex/assistant-chat-history-20261118
Nov 18, 2026
Merged

zerodrift merged 2 commits into
masterfrom
codex/assistant-chat-history-20261118

Conversation

@zerodrift

@zerodrift zerodrift commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Walkthrough guidance now stays with its answer across history reloads, and an incompatible saved presentation action no longer discards surrounding chat. Continue rechecks current access after a pause; the final pause explicitly offers Finish walkthrough.

Adds an unchecked Allow searching my chat history checkbox. Consent is recorded with the question and preserved on retries. Search returns bounded, dated excerpts from the owner's earlier workspace conversations in the same entry-point scope, with source permissions retained through publication and replay.

Includes migration 0365_assistant_history_search.sql and assistant runtime turns_v23. Rollout requires matching schema, API and browser assets; this PR does not activate or deploy them.

Verification also inventories the new table and runtime operation, revokes the history fixture's temporary grant before browser consent checks, and gives queued risk browser actions the same bounded completion budget as their result assertions.

Validation:

  • 121 assistant/settings frontend checks, including real mouse and keyboard walkthrough controls, retained messages, and consent retry recovery.
  • Managed assistant workspace, prompt and tool contracts.
  • 79 workspace integration checks against disposable stock PostgreSQL and synthetic providers, including owner isolation, pagination, immutable consent and permission revocation.
  • Existing runtime regressions: 108 turn checks, 22 HTTP turn checks, 65 HTTP tool checks, 20 HTTP stream checks and 44 usage checks.
  • 296 assistant/settings browser checks, 10 physical-assistant browser checks and 44 workspace-assistant browser checks.
  • The affected risk integration scenario and all 170 of its browser checks, plus bounded action-wait checks.
  • Independent adversarial review has no remaining material finding.

The complete release gate remains required before release publication.

Signed-off-by: zerodrift <zerodrift@users.noreply.github.com>
@zerodrift
zerodrift enabled auto-merge November 18, 2026 18:55
Keep history-search security inventory current, revoke the temporary foreign-owner grant, and allow queued risk checks their existing bounded completion budget.

Signed-off-by: zerodrift <zerodrift@users.noreply.github.com>
@zerodrift
zerodrift merged commit d14b273 into master Nov 18, 2026
24 checks passed
@zerodrift
zerodrift deleted the codex/assistant-chat-history-20261118 branch November 18, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant