Skip to content

zgx: the title bar's controls sit on the traffic lights' line - #1229

Closed
gaelcado wants to merge 1 commit into
zeronsh:zeron/zgxfrom
gaelcado:gael/zgx-day-titlebar
Closed

gaelcado wants to merge 1 commit into
zeronsh:zeron/zgxfrom
gaelcado:gael/zgx-day-titlebar

Conversation

@gaelcado

@gaelcado gaelcado commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

zgx's inset title bar on macOS centres the traffic lights in its 40-point strip, so their middle is 20 points down. The bar still used old Zeron's 21, so every control sat a point under the lights. On macOS the bar's line is now the lights' own middle, or 20 with none reported (full screen). Windows and Linux don't change: on Windows the line is still the caption buttons' middle, and on GNOME it's the bar's 21.

Cherry-picked from the integration branch (df2adf6).

macOS, before / after (dark)

Rendered headless from the shell fixture with the platform set to "macos" and the inset bar's reported lights (12,12 60×16). The lights are drawn into the picture at that frame, and the magenta line is their middle (20). No macOS machine was available here.

before after
before after

Windows (VM), caption buttons on the right

The chat's title (its tab on the top bar), the sidebar controls and the panel toggle all sit on the caption buttons' line (16 down). No change from this PR there; the screenshot is from this build.

windows
windows line

Tests

  • window_buttons_tests (the integration test): the macOS line is 20 with the lights reported and in full screen. The Windows test (16) and the GNOME test (21) still pass.
  • cargo test --release --no-fail-fast: the only failures were already on the base, plus plugins::network_tests::a_plugin_s_picture_is_held_to_the_rule, which this change doesn't touch.
  • Luau zgx test .: 849 passed, 8 failed. The same 8 fail on the base (About, Appshots, editor menu, plugin settings).

Platforms: Linux (fixture render), Windows check (xwin-check.sh) passes, Windows VM screenshot attached.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

zgx's inset title bar centres macOS's buttons in its 40-point strip, 20
down; the bar kept old Zeron's 21, so every control stood a point under
the lights. On macOS the line is now the lights' own middle, 20 with
none reported (full screen).

Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
(cherry picked from commit df2adf6)
@gaelcado

gaelcado commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Folded into #1232.

@gaelcado gaelcado closed this Nov 5, 2026
@gaelcado
gaelcado deleted the gael/zgx-day-titlebar branch November 8, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant