Repository navigation
Conversation
zgx's inset title bar centres macOS's buttons in its 40-point strip, 20 down; the bar kept old Zeron's 21, so every control stood a point under the lights. On macOS the line is now the lights' own middle, 20 with none reported (full screen). Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com> (cherry picked from commit df2adf6)
Contributor
Author
|
Folded into #1232. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zgx's inset title bar on macOS centres the traffic lights in its 40-point strip, so their middle is 20 points down. The bar still used old Zeron's 21, so every control sat a point under the lights. On macOS the bar's line is now the lights' own middle, or 20 with none reported (full screen). Windows and Linux don't change: on Windows the line is still the caption buttons' middle, and on GNOME it's the bar's 21.
Cherry-picked from the integration branch (df2adf6).
macOS, before / after (dark)
Rendered headless from the shell fixture with the platform set to "macos" and the inset bar's reported lights (12,12 60×16). The lights are drawn into the picture at that frame, and the magenta line is their middle (20). No macOS machine was available here.
Windows (VM), caption buttons on the right
The chat's title (its tab on the top bar), the sidebar controls and the panel toggle all sit on the caption buttons' line (16 down). No change from this PR there; the screenshot is from this build.
Tests
window_buttons_tests(the integration test): the macOS line is 20 with the lights reported and in full screen. The Windows test (16) and the GNOME test (21) still pass.cargo test --release --no-fail-fast: the only failures were already on the base, plusplugins::network_tests::a_plugin_s_picture_is_held_to_the_rule, which this change doesn't touch.zgx test .: 849 passed, 8 failed. The same 8 fail on the base (About, Appshots, editor menu, plugin settings).Platforms: Linux (fixture render), Windows check (
xwin-check.sh) passes, Windows VM screenshot attached.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.