Skip to content

zgx: every page shares one layout (title, gutter, top) - #1235

Draft
gaelcado wants to merge 8 commits into
zeronsh:zeron/zgxfrom
gaelcado:gael/zgx-day-pages
Draft

gaelcado wants to merge 8 commits into
zeronsh:zeron/zgxfrom
gaelcado:gael/zgx-day-pages

Conversation

@gaelcado

@gaelcado gaelcado commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Every page in the page's card is one page now (ds/page, ds.Page: title, line under it, actions on the title's line, flush tabs), used by Settings' pages, Plugins, Themes, Templates, Archived, Members, Devices, Providers, Account and GitHub's pull request board. They share one gutter (32, 16 in a card under 640) and one top, and every word outside a card stands on the cards' edge. Also: a plugin's page no longer starts ~34 pt down (a pre-v3 leftover of the old title strip), and the window frame's 42 (top bar) and 5 (rim) are named once instead of copied as numbers.

Carries the intent of #449/#484 (one page layout, the title on the cards' edge); none of their code or values.

Kept from Wing: the centred column, the board's wide column (960: its rows carry status, checks and who at their ends; only its title moved to Settings' top and style), the new chat's composer placed by layout (96f9f68), the transcript's 12 pt overhang (Dock.OVERHANG). Dropped from the earlier draft: the composer centring, the transcript/composer and loading-row widths, the expanded-panel width fix, and the sidebar connection line (goes to #1231).

Question for Gaël: the page's top

The title stood 16 under the card's top and read pressed against the top bar and level with the sidebar's first row. Applied: 32 (space.6): the page's own gutter and rhythm (header to content, section to section are 32) and the room the composer keeps from a chat page's sides (Dock.SIDES), so the column is inset evenly from the card's top and sides. 24 still reads tight under the bar; 48 starts to float away from the sidebar's list. Which one?

top candidates

Before / after (1400×900, dark, shell fixture; the board with GitHub played)

Settings → Appearance
appearance

Settings → General
general

Pull request board (wide column kept)
board

A narrow card (860×800): 16 pt gutter, same top
general narrow
board narrow

Tests

One integration test, ui/tests/page_gutters.test.luau: the title's top, its box on every page and on the cards' edge, the gutters and the plugin page's top, at 1400 and 860. GitHub's board keeps Settings' title top and line in github_s_board_stands_its_title_where_settings_does (Rust, the plugin loaded in the shell). settings_in_place's code font test scrolls to its row now (32 more points above it).

Rebased on zeron/zgx 224189a (zgx pin 0f0aa6a1); Wing's b49b7d0 (a section's folded count on the others' line) kept as is, no conflict left in ds/sidebar.luau.
Luau zgx test .: 915 passed, 8 failed, the same 8 as on a clean zeron/zgx 224189a on Linux. Lint: 0 errors.
Rust cargo test --release --no-fail-fast: no new failures against a clean 224189a (two plugin tests failed under load and pass alone). github_s_board_stands_its_title_where_settings_does passes. xwin-check.sh passes; the pin itself doesn't compile off macOS (zgx-gpu's loops_said is ungated), so Linux and Windows were built with that one field gated locally, which isn't part of this PR.
Zeron v2's .base.json re-blessed in its own commit; zeron_v2_is_in_step passes.

Note: ds/page.luau is a new design-system file lent to plugins as @ds/page; if a running app's live copy of ds predates it, GitHub's board fails to load until a relaunch.

Overlap with #1230: both touch screens/settings/appshots.luau (#1230 wraps the macOS-only rows in a platform check; this PR drops pl = ds.Settings.inset() to put the words on the cards' edge). Whichever merges second takes both.

gaelcado added a commit to gaelcado/comet that referenced this pull request Nov 5, 2026
Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
@gaelcado gaelcado changed the title zgx: every page shares one layout (title, gutter, top, column) zgx: every page shares one layout (title, gutter, top) Nov 5, 2026
gaelcado and others added 8 commits November 6, 2026 09:22
… cards)

The 42-point top bar and the 5-point window edge round the cards were
copied as bare numbers into the page, the sidebar (both of them), the
settings' list and the fit's page edges. They're zeron.inset.top and
zeron.inset.rim now, beside zeron.inset.gap, and settings' list gap and
its 1-point step in are worked out from them. Nothing moves.

Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
Its area was still set down by the old title strip (38 less the gap),
which v3 moved over the cards: the board's heading stood 34 points under
Settings' and the transcript's. It fills the card now, and the page keeps
its own top.

Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
… top

Settings' pages (Plugins, Templates and Themes among them) kept 32 each
side at every width, while the pull request board and viewer tightened to
16 under 640. One rule now, ds/layout's gutter (space.6, space.4 under
its NARROW 640), used by all three, and one top for their first words
(ds/layout TOP, 16, where a transcript's first message stands): the
board's was 24. The board keeps its wider column, 960 as ds/layout WIDE:
its rows carry status, checks and who at their ends. (Standard steps
chosen in ds/layout, not new tokens: Zeron v2's own tokens file would
not have them.)

Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
Settings' pages, the catalogs (Plugins, Themes, Templates) and their
sections now come from one page component (ds/page, ds.Page): one title
style (Text's new headline, xl semibold), one line under it, actions on
the title's line, flush underline tabs, and every word outside a card on
the column's edge (the cards' edge), no longer 17 in at the rows' words.
Settings.Page and Settings.Catalog are that page; trail_top is actions.

Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
The board was a page of its own: a 28pt title, its project chip under
the title, its tabs and gaps its own. It's ds.Page in ds/page's Frame
now: Settings' title at Settings' top, the repository as its line, the
project and refresh on the title's line. It keeps its wide column (960):
its rows carry status, checks and who at their ends.

Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
… narrow

Settings' first words at the page's top under the card's, its column on
the gutter (32, or 16 in a narrow card), its pages' titles in one box on
their cards' edge, and a plugin's page at the card's inner top where
Settings' starts, at 1400 and 860 points.

Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
16 under the card's edge, the title read pressed against the top bar and
level with the sidebar's first row. 32 is the page's gutter and its own
rhythm (header to content, section to section), and the room the
composer keeps from a chat page's sides: the title clears the bar and
the card's corner, with Settings, the catalogs, the pull request board
and its viewer together.

Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant