Repository navigation
CI admission: zgx betas join the queue as releases - #1359
Open
katulevskiy wants to merge 7 commits into
Open
katulevskiy wants to merge 7 commits into
katulevskiy wants to merge 7 commits into
Conversation
zgx-beta.yml gets an admit job, which every other job needs through version. Its name carries the reservation and the release class: a tag's beta reserves 9 Linux, 3 Windows and 2 macOS runners; one by hand only its platforms', with the macOS package job, which has no approval to wait for then. On a tag that job waits for apple-release's reviewers, so it's left out and counts once approved and queued. admit.py, its tests and the admission docs as on main (zeron/ci-release- admission): releases go first in the shared queue, verified by workflow and event, and peers' release workflows are read too.
This was referenced Nov 11, 2026
CI admission: releases join the queue shared with zeron as a verified release class
zeronsh/zgx#2039
Open
zeron/zgx moved the beta's builds into zgx-build.yml, which zgx-beta.yml calls. The beta's admit job now sits in front of that call (build needs version and admit) and reserves what the run takes: on a tag, version, zgx-build's Linux x64 + arm and Windows, and release + channel (5 Linux, 1 Windows; macOS waits for apple-release's approval and counts once queued); by hand, version and the platforms named.
…lookup, janitor's pass records, zeron/zgx trusted only when protected, no restoring a pull request's own zgx CLI
…only The release workflows' runs were read from their latest 30, whatever the event. A fork's pull requests can run an edited copy of a release workflow (on pull_request), and enough of them pushed a real release out of the window: it waited as an ordinary run, or wasn't seen at all. They're listed for the two events that start a release, `push` and `workflow_dispatch`, 30 each. A pull request's runs of a release workflow are outside runs now, seen as what they run.
Admission is documented to fail open, but only admit.py's own errors did: a crash (an exception it doesn't catch) failed the admit job, and every job with `needs: admit` was skipped. zgx-beta.yml's admit step continues on error, so its job succeeds and the beta goes on, and has a timeout of its own, shorter than the job's, so a hang ends the same way rather than cancelling the job.
The 4-digit cap kept a giant number in an edited admit name from raising in int(), but would also have stopped pull requests numbered 10000 and up from claiming ci:priority or ci:lock (zgx is past 2000, ~70 a day). Pull request numbers take up to 7 digits; reservations stay at 4.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to CI stage 1. The heavy release and beta workflows join the shared admission queue as a verified, top-priority release class. It's stacked on the stage-1 PR named in its base, so review that first.
Why
Until now, releases and betas weren't admitted. Admission only counted their running and queued jobs as taken. Their later jobs (packaging after the builds) didn't count until GitHub created them, so CI could be admitted into runners those jobs needed minutes later, and releases couldn't be steered.
Changes
admit.py).releasein its admit job's name (admit [linux=… windows=… macos=…] release).ci:lock(oldest first), thenci:priority, then everyone.CI_LOCK_HOURS.RELEASE_WORKFLOWS, orCI_RELEASE_WORKFLOWS), triggered byworkflow_dispatchor by a push of a tag that the API confirms points at the run's commit. A pull request, or any other workflow, claimingreleaseis an ordinary run.admitjob reserving all its jobs:release.yml: linux 5, windows 1.zgx-beta.yml: linux 9, windows 3, macos 2 on tags; only the chosenplatformson a run by hand.release.yml: one of each.apple-release). A job in statuswaitingholds no runner; it counts once it's queued.CI_PEERStakes several workflows per repo, and older values keep working.plan+admitwould cost more than the job itself, and reserving across a human approval would block CI for nothing.CI_ADMISSION=offthey start at once.Verified
mainbranch: 120 tests pass;zeron/zgxbranch: 123; zgx: 67. All run with PyYAML, so the workflow-consistency checks ran too.admit.pyis byte-identical across the three, and the vendored copy's hash test passes.Linked PRs
Release admission (this follow-up):
CI stage 1: #1356, #1357, zeronsh/zgx#2037