Skip to content

zgx sidebar: chats that share a title show where they run - #1443

Open
Gratenes wants to merge 1 commit into
zeronsh:mainfrom
Gratenes:zgx/same-title-location
Open

Gratenes wants to merge 1 commit into
zeronsh:mainfrom
Gratenes:zgx/same-title-location

Conversation

@Gratenes

@Gratenes Gratenes commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Chats that share a title (the same name on several devices) look identical in the default compact sidebar rows, which show only the title. Rows are keyed by chat id throughout, so nothing merges or opens the wrong chat; the rows just can't be told apart, most visibly in the flat Activity list.

A row whose title another listed chat shares (case-insensitive) now shows its second line, "Project · Device", even in compact mode and even with the location setting off. Chats with a unique title stay one line. Applies to the default sidebar and Zeron v2's copy (.base.json updated for ds/sidebar.luau).

Tests: a twins fixture in shell_fixture.luau and tests/same_title.test.luau (rows say where they run, a row opens its own chat after another of the same name finishes or sleeps, unique titles stay one line). The first fails without the change.

I ran the new tests and the Activity and sidebar suites with a zgx build older than this branch; failures there also fail without this change. I did not run the Rust zeron_v2_is_in_step test, so please let CI confirm the .base.json hash.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Rows are keyed by chat id throughout, so same-titled chats never merged,
but compact rows (the default) show only the title: three "School
Management" chats on different devices read as identical, and nothing
told them apart. A row whose title another listed chat shares now shows
its second line (project and device) even in compact mode, whatever the
location setting says. Applies to the default sidebar and Zeron v2's copy
(.base.json blessed). Adds a `twins` fixture and tests/same_title.test.luau.
@Gratenes
Gratenes force-pushed the zgx/same-title-location branch from 62cfe02 to d97bdef Compare November 18, 2026 01:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant