Repository navigation
Conversation
Rows are keyed by chat id throughout, so same-titled chats never merged, but compact rows (the default) show only the title: three "School Management" chats on different devices read as identical, and nothing told them apart. A row whose title another listed chat shares now shows its second line (project and device) even in compact mode, whatever the location setting says. Applies to the default sidebar and Zeron v2's copy (.base.json blessed). Adds a `twins` fixture and tests/same_title.test.luau.
Gratenes
force-pushed
the
zgx/same-title-location
branch
from
November 18, 2026 01:40
62cfe02 to
d97bdef
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chats that share a title (the same name on several devices) look identical in the default compact sidebar rows, which show only the title. Rows are keyed by chat id throughout, so nothing merges or opens the wrong chat; the rows just can't be told apart, most visibly in the flat Activity list.
A row whose title another listed chat shares (case-insensitive) now shows its second line, "Project · Device", even in compact mode and even with the location setting off. Chats with a unique title stay one line. Applies to the default sidebar and Zeron v2's copy (
.base.jsonupdated fords/sidebar.luau).Tests: a
twinsfixture inshell_fixture.luauandtests/same_title.test.luau(rows say where they run, a row opens its own chat after another of the same name finishes or sleeps, unique titles stay one line). The first fails without the change.I ran the new tests and the Activity and sidebar suites with a
zgxbuild older than this branch; failures there also fail without this change. I did not run the Rustzeron_v2_is_in_steptest, so please let CI confirm the.base.jsonhash.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.