Repository navigation
Settings: the worktree switch flips before a folder exists, and the engine's own words are shown - #1493
Open
syntony666 wants to merge 2 commits into
Open
Settings: the worktree switch flips before a folder exists, and the engine's own words are shown#1493syntony666 wants to merge 2 commits into
syntony666 wants to merge 2 commits into
Conversation
…ngine's own words are shown
A wait pumps frames as fast as the host draws, so on a fast runner the whole ease can pass between two of a test's reads: every sample landed at the end state, and no mid-ease state was ever seen. Sampling per delivered frame steps the animation's own clock, so the states between are always there to read.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetWorktreeSettingsgoes to the engine only once a folder is known (typed and committed, or remembered) or when turning off — so a fresh install's "Choose a worktree folder" rejection can no longer dead-end the feature.unknown method→ outdated and offline/signed-out mappings are unchanged.crates/ui.Fixes #1395
Test plan
a worktree folder is asked for before the engine is, and a refusal is said in the engine's words— verified it fails without the fix: toggle on with no folder → field appears, zeroSetWorktreeSettingscalls; folder + Enter → one call and the description updates; toggle off → second call, field hidden, folder kept; an engine rejection is shown in its own wordszgx test ui— 1425 passed, 0 failedcargo test --locked --bin zeron-zgx— 718 passed, 1 failed:plugins::preview::tests::every_action_the_code_refuses_is_blocked, which fails onmaintoo (agents.cloud_keyis refused inagents.rsbut missing from the BLOCKED list; unrelated to this change)shell_fixturewindow withzgx inspect— screenshots belowScreenshots
before/afterimages attached belowOpen in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.