Repository navigation
zgx: Linux windows carry zeron.desktop's id, so bars and docks show Zeron's icon - #1505
Open
grishnakov wants to merge 1 commit into
Open
grishnakov wants to merge 1 commit into
grishnakov wants to merge 1 commit into
Conversation
…eron's icon
A window's Wayland app_id (X11 class) is what bars, docks and task
switchers match to a desktop file for the app's name and icon. zgx took
it from the application id, sh.zeron.app in the beta, or else the
executable's name, zeron-zgx in a development build. The desktop entry
Linux installs is zeron.desktop (StartupWMClass=zeron), so neither
matched and Zeron showed with no icon. Application::desktop_id("zeron")
names the windows after it in every build; it registers nothing on
D-Bus, so the beta's sh.zeron.app URL delivery is unchanged.
katulevskiy
approved these changes
Nov 18, 2026
katulevskiy
left a comment
Contributor
There was a problem hiding this comment.
1-line fix, correct fix, approved
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets #1474 (
zeron/orchestrators).Problem
On Linux, Zeron's windows show without an icon in bars, docks and task switchers. That happens in both the released beta and development builds of the zgx app.
Bars match a window's Wayland
app_id(the X11 class) to a desktop file to find the app's name and icon. zgx-desktop takes that id fromApplication::application_id, or else from the executable's name:zeron.desktop?--features beta)sh.zeron.appzeron-zgxLinux installs the entry as
zeron.desktop, withStartupWMClass=zeron(dist/zeron.desktop,scripts/package-linux.sh), so neither id matches.Fix
Set
Application::desktop_id("zeron")inapps/zgx/src/main.rs. zgx-desktop makes for exactly this case. On Linux it sets the windows' app_id and X11 class, and it takes precedence over the application id. It registers nothing on D-Bus, so the beta'ssh.zeron.appURL delivery (zeron://links) is unchanged. On macOS and Windows it does nothing.Tested
Tested on Omarchy (Hyprland, Quickshell bar) with this branch's dev build against production:
hyprctl clientsgaveclass: zeron-zgx, and the workspace bar showed no icon.class: zeron, and the bar shows Zeron's logo fromzeron.desktop.I didn't build or run the beta (
--features beta) variant. The change is the same builder call, and zgx-desktop usesdesktop_idahead ofapplication_id.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.