Repository navigation
Conversation
Oh My Pi is a different product from stock Pi. Leave the existing Pi slot on pi-acp and register a native `omp acp` harness beside OpenCode instead of replacing either one.
Thytu
force-pushed
the
pi-prefer-omp-acp
branch
from
August 19, 2026 18:30
b7cdf33 to
8ce5eab
Compare
|
any news on this |
|
merge soon @wing-anara ? |
|
basic human need. |
hoangvu12
added a commit
to hoangvu12/roboco
that referenced
this pull request
Oct 13, 2026
…h#87) The + pull-down (Photo Library / Take Photo / Choose File / Paste Image) built on every open over ticket 15's GlassMenuHost, and the staging pipeline (2560 px decode-time downsample, JPEG 86, 24 MiB cap, 180 px thumb, image-<8hex>.jpg) delivering one addImages batch: - ImageStaging.kt: PickedImage + the stage/stageAll/encode pipeline (ALLOCATOR_SOFTWARE, sRGB, silent drops, stop-at-limit) - AttachMenu.kt: attachMenu builder, PickImages contract (limit as the launch input), AttachPicker + rememberAttachPicker (clipboard check by description only; FileProvider camera captures; ActivityNotFoundException guards), clipHasImage, cameraPermissionDeclared - ComposerAttachMenuButton.kt: 55's button as the menu anchor with the composerControl marker (PR zeronsh#714: no focus, no morph, no movement) - file_paths.xml + the manifest FileProvider (no CAMERA permission) - AttachMenuGallerySection + the gallery registration (live stage skipped under capture) - tests: AttachMenuModelTest (plain JVM), ImageStagingTest and AttachMenuBehaviourTest (Robolectric) and AttachMenuScreenshotTest (Roborazzi), all not run locally (VPS)
17 of 19 tasks
Contributor
|
Thank you for this. Zeron v3, the new desktop app in apps/zgx, replaces the old desktop in crates/ui that this PR changes, so we're closing it. Oh My Pi is covered by #930, the native RPC harness, which already works with v3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm daily driving omp and was missing the selector for it.
pi-acp/npx -y pi-acp@0.0.33piCLIomp acpompCLIBoth stay opt-in in Settings → Agents. Existing Pi chats keep the
piharness id. Oh My Pi is a newoh-my-piid.PI_ACP_EXECUTABLEstill forces the Pi adapter;OMP_EXECUTABLEonly picks the Oh My Pi binary.cargo test -p zeron-harness --test shell_env_resolution --test acp -- --skip real_cargo test -p zeron-engine --lib registry