Skip to content

Add async person gateway APIs - #27

Merged
zigdanis merged 5 commits into
codex/concurrency-image-storefrom
codex/concurrency-async-api
Aug 3, 2026
Merged

Add async person gateway APIs#27
zigdanis merged 5 commits into
codex/concurrency-image-storefrom
codex/concurrency-async-api

Conversation

@zigdanis

@zigdanis zigdanis commented Aug 1, 2026

Copy link
Copy Markdown
Owner

What

Adds async/throws APIs alongside the existing callback gateway and use-case methods.

  • bridges callback gateways with checked continuations
  • exposes async add, edit, remove, fetch, and widget-fetch operations
  • makes CachePersonsGateway own the structured async implementation
  • checks cancellation before side effects and before database commits
  • keeps callback call sites compiling for the final migration layer

Checks

  • scripts/check-formatting.sh
  • scripts/check-secrets.sh
  • swiftc parse check for changed Swift files
  • focused async success, error propagation, and cancellation tests in CI

Stack #25, above PR #26.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zigdanis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c2364c1c-28f8-4f22-ae81-8fefccba6ebd

📥 Commits

Reviewing files that changed from the base of the PR and between 3d36ded and 68c2e91.

📒 Files selected for processing (14)
  • Core/EntityGateway/Cache/CachePersonsGateway.swift
  • Core/Gateways/PersonsGateway.swift
  • Core/UseCases/AddPersonUseCase.swift
  • Core/UseCases/EditPersonUseCase.swift
  • Core/UseCases/FetchPersonsUseCase.swift
  • Core/UseCases/RemovePersonUseCase.swift
  • GrowingUpTests/Gateways/CachePersonsGatewayTests.swift
  • GrowingUpTests/Helpers/UserCases/AddPersonUseCaseSpy.swift
  • GrowingUpTests/Helpers/UserCases/DisplayPersonsUseCaseSpy.swift
  • GrowingUpTests/Helpers/UserCases/EditPersonUseCaseSpy.swift
  • GrowingUpTests/Helpers/UserCases/FetchPersonsUseCaseSpy.swift
  • GrowingUpTests/Helpers/UserCases/RemovePersonUseCaseSpy.swift
  • GrowingUpTests/UseCases/AddPersonUseCaseTests.swift
  • GrowingUpTests/UseCases/FetchPersonsUseCaseTests.swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zigdanis

zigdanis commented Aug 1, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@zigdanis
zigdanis marked this pull request as ready for review August 1, 2026 19:30
@zigdanis

zigdanis commented Aug 1, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@zigdanis

zigdanis commented Aug 1, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 59 minutes.

@zigdanis
zigdanis force-pushed the codex/concurrency-async-api branch 2 times, most recently from 8c8feef to 89bf339 Compare August 1, 2026 19:57
@zigdanis
zigdanis force-pushed the codex/concurrency-async-api branch from 89bf339 to 20d0701 Compare August 2, 2026 06:14
@zigdanis
zigdanis merged commit aef4c3b into master Aug 3, 2026
6 checks passed
@zigdanis
zigdanis deleted the codex/concurrency-async-api branch August 3, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant