Skip to content

补齐部署模板 stop_grace_period #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zj1123581321 merged 1 commit into from
Oct 6, 2026
Merged

补齐部署模板 stop_grace_period #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docker/docker-compose.deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ services:
- .env
ports:
- "8200:8000"
# 必须大于内部关闭预算 20s，否则 SIGKILL 可能打断优雅关闭流程。
stop_grace_period: 30s
volumes:
- ./config:/app/config
- ./data:/app/data
Expand Down
8 changes: 8 additions & 0 deletions tests/deployment/test_pull_and_deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import time
from pathlib import Path

import yaml


SCRIPT = Path(__file__).parents[2] / "docker" / "pull_and_deploy.sh"
PUSH_SCRIPT = Path(__file__).parents[2] / "docker" / "push_to_ghcr.sh"
Expand Down Expand Up @@ -444,6 +446,12 @@ def test_compose_template_uses_legacy_compatible_env_file_syntax():
assert "- .env" in source


def test_compose_template_sets_stop_grace_period():
source = (SCRIPT.parent / "docker-compose.deploy.yml").read_text(encoding="utf-8")
compose = yaml.safe_load(source)
assert compose["services"]["video-transcript-api"]["stop_grace_period"] == "30s"


def test_build_script_uses_only_git_sha_tag():
source = PUSH_SCRIPT.read_text(encoding="utf-8")
assert 'IMAGE_REF="${REGISTRY_IMAGE}:${GIT_SHA}"' in source
Expand Down
Loading