Repository navigation
清理 #180 终审遗留：删 notes_processor 不可达守卫，修正测试表述，补纯空白输入用例 (#185) - #189
Merged
Merged
Conversation
Refs #185 Agent-Executor: agy Agent-Model: gemini-3.8-flash-high Agent-Effort: unknown Dispatch-Id: dlg-20261006-104938-bec2ec Task-Id: VideoTranscriptAPI-20261006-06
Required Gate v2 — 状态面板当前状态：pass · 可合并 当前裁决：
Gate 历史（v1；来源为持久化
|
| Run | Attempt | Head | 状态 | 收件人动作 |
|---|---|---|---|---|
| 37453834702 | 1 | ac3f1a9 |
pass |
可合并 |
历史行按 run_id + run_attempt 去重并只增不删；删除本评论后可由 gate_terminal 制品重建。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
清理 #180 终审遗留（issue #185），三个文件一处语义测试补齐，无可执行行为变更：
notes_processor.py：删除不可达的if not mapping.slices:守卫（is_valid已要求非空 slices，:464 处即返回 FAILED）。test_empty_input_processors.py：test_notes_processor_empty_slices_returns_failed_result改名test_notes_processor_empty_chapters_fails_validation并加注释——该测试实际锁定的是空 chapters → is_valid 校验失败路径，删除新守卫后它仍绿（codex 终审红验已证）。test_plain_text_process_whitespace_only_text：纯空白输入" \t\n"交付空串、零 LLM 调用，锁定既有语义。tests/README.md:169：收紧表述，区分「空列表直返（plain/speaker_aware）」与「空 chapters 校验失败（notes）」两条路径。验证
grep -rn "not mapping.slices" src/零命中uv run pytest tests/unit/test_empty_input_processors.py -q7 passed[text] if text.strip() else []改成[text]，新增用例变红；恢复后转绿make test全量通过（跳过 tests/manual）Fixes #185