Repository navigation
将 BBDown COPY --from 改为独立 stage 避开 BuildKit 变量展开限制 - #255
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com> Agent-Executor: cursor Agent-Model: cursor-grok-4.6-high Agent-Effort: unknown Dispatch-Id: dlg-20261016-034250-e86936 Task-Id: VideoTranscriptAPI-20261015-11
Required Gate v2 — 状态面板当前状态:pass · 可合并 当前裁决: PR 累计主审轮(影子):
Gate 历史(v1;来源为持久化
|
| Run | Attempt | Head | 状态 | PR 累计主审轮(影子) | 收件人动作 |
|---|---|---|---|---|---|
| 38847550926 | 1 | 0ae3abd |
pass |
1/5 · collecting |
可合并 |
历史行按 run_id + run_attempt 去重并只增不删;删除本评论后可由 gate_terminal 制品重建。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variable expansion is not supported for --from,COPY --from=${BBDOWN_FROM}不能用。ARG BBDOWN_FROM放到全局作用域(所有FROM之前),增加FROM ${BBDOWN_FROM} AS bbdown独立 stage,主 stage 用静态名COPY --from=bbdown /app/BBDown /app/BBDown。默认值仍指向 ACRbbdown-base。--build-arg BBDOWN_FROM=<含 BBDown 的等效镜像>。Follow-up to #254. Related: #249.
Test plan
grep -c "ARG BBDOWN_FROM=" docker/Dockerfile=> 1,且位于FROM python:3.11-slim之前grep -c "COPY --from=bbdown" docker/Dockerfile=> 1grep -c "ghcr.io/zj1123581321/video-transcript-api:latest" docker/Dockerfile=> 0docker build --build-arg BBDOWN_FROM=python:3.11-slim -f docker/Dockerfile:已执行到COPY --from=bbdown(无 variable expansion 报错);该 smoke 镜像无/app/BBDown,故 COPY 文件缺失失败是预期:bbdown-base后应能拉到真实 BBDown 二进制Made with Cursor