Repository navigation
修复分享卡片文案在 _build_result_dict 中被丢弃 - #256
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com> Agent-Executor: cursor Agent-Model: cursor-grok-4.6-high Agent-Effort: unknown Dispatch-Id: dlg-20261016-050106-339b2d Task-Id: VideoTranscriptAPI-20261016-05
Co-authored-by: Cursor <cursoragent@cursor.com> Agent-Executor: cursor Agent-Model: cursor-grok-4.6-high Agent-Effort: unknown Dispatch-Id: dlg-20261016-050106-339b2d Task-Id: VideoTranscriptAPI-20261016-05
zj1123581321
marked this pull request as ready for review
October 16, 2026 05:25
Required Gate v2 — 状态面板当前状态:pass · 可合并 当前裁决: PR 累计主审轮(影子):
Gate 历史(v1;来源为持久化
|
| Run | Attempt | Head | 状态 | PR 累计主审轮(影子) | 收件人动作 |
|---|---|---|---|---|---|
| 38854885918 | 1 | 4ec8146 |
skipped |
— |
无需动作(主审未跑,绿≠过审) |
| 38855714735 | 1 | 4ec8146 |
pass |
1/5 · collecting |
可合并 |
历史行按 run_id + run_attempt 去重并只增不删;删除本评论后可由 gate_terminal 制品重建。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_build_result_dict在协调器结果含share_card时原样带入result_dict,并同时带入share_card_error;不含该键时不写入,保持「无此键不动卡片」。_save_llm_results静默跳过,线上零落盘。_build_result_dict→_save_llm_results,断言缓存目录写出llm_share_card.json且 headline/points 与输入一致。Test plan
uv run --frozen pytest -q tests/unit/test_share_card_pipeline_wiring.pyuv run --frozen pytest -q tests -k share_cardmake test_build_result_dict的 share_card 带入后,新测试以 AssertionError 转红;还原后复绿Made with Cursor