Skip to content

修复分享卡片文案在 _build_result_dict 中被丢弃 - #256

Merged
zj1123581321 merged 2 commits into
mainfrom
card/vta-261016-card-passthru
Oct 16, 2026
Merged

zj1123581321 merged 2 commits into
mainfrom
card/vta-261016-card-passthru

Conversation

@zj1123581321

Copy link
Copy Markdown
Collaborator

Summary

  • _build_result_dict 在协调器结果含 share_card 时原样带入 result_dict,并同时带入 share_card_error;不含该键时不写入,保持「无此键不动卡片」。
  • 此前协调器已生成卡片,但重建 result_dict 时丢掉该键,导致 _save_llm_results 静默跳过,线上零落盘。
  • 测试从协调器返回形状走 _build_result_dict → _save_llm_results,断言缓存目录写出 llm_share_card.json 且 headline/points 与输入一致。

Test plan

  • uv run --frozen pytest -q tests/unit/test_share_card_pipeline_wiring.py
  • uv run --frozen pytest -q tests -k share_card
  • make test
  • 最小注入红验:删掉 _build_result_dict 的 share_card 带入后,新测试以 AssertionError 转红;还原后复绿

Made with Cursor

zj1123581321 and others added 2 commits October 16, 2026 13:07
Co-authored-by: Cursor <cursoragent@cursor.com>
Agent-Executor: cursor
Agent-Model: cursor-grok-4.6-high
Agent-Effort: unknown
Dispatch-Id: dlg-20261016-050106-339b2d
Task-Id: VideoTranscriptAPI-20261016-05
Co-authored-by: Cursor <cursoragent@cursor.com>
Agent-Executor: cursor
Agent-Model: cursor-grok-4.6-high
Agent-Effort: unknown
Dispatch-Id: dlg-20261016-050106-339b2d
Task-Id: VideoTranscriptAPI-20261016-05
@zj1123581321 zj1123581321 self-assigned this Oct 16, 2026
@zj1123581321
zj1123581321 marked this pull request as ready for review October 16, 2026 05:25
@github-actions

Copy link
Copy Markdown

Required Gate v2 — 状态面板

当前状态:pass · 可合并

当前裁决:code_pass / primary_pass

PR 累计主审轮(影子):1/5 · collecting

历史可能不完整:1 个制品处理失败:URLError;1 个历史重建预算耗尽

Gate 历史(v1;来源为持久化 gate_terminal 制品)

Run Attempt Head 状态 PR 累计主审轮(影子) 收件人动作
38854885918 1 4ec8146 skipped — 无需动作(主审未跑,绿≠过审)
38855714735 1 4ec8146 pass 1/5 · collecting 可合并

历史行按 run_id + run_attempt 去重并只增不删;删除本评论后可由 gate_terminal 制品重建。

@zj1123581321
zj1123581321 merged commit a6471bc into main Oct 16, 2026
26 checks passed
@zj1123581321
zj1123581321 deleted the card/vta-261016-card-passthru branch October 16, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant