Repository navigation
分享卡片文案改用独立可配置的 share_card_model - #260
Merged
Merged
Conversation
卡片短文案不应再绑 summary 的贵模型；未配置时仍回退 summary，行为与改前一致。 Co-authored-by: Cursor <cursoragent@cursor.com> Agent-Executor: cursor Agent-Model: cursor-grok-4.6-high Agent-Effort: unknown Dispatch-Id: dlg-20261016-082932-f7ad6e Task-Id: VideoTranscriptAPI-20261016-08
zj1123581321
marked this pull request as ready for review
October 16, 2026 08:49
Required Gate v2 — 状态面板当前状态：pass · 可合并 当前裁决： PR 累计主审轮（影子）： Gate 历史（v1；来源为持久化
|
| Run | Attempt | Head | 状态 | PR 累计主审轮（影子） | 收件人动作 |
|---|---|---|---|---|---|
| 38875225058 | 1 | e4be5d5 |
fail |
— |
要修代码 |
| 38876250203 | 1 | e4be5d5 |
fail |
— |
要修代码 |
| 38876250203 | 2 | e4be5d5 |
pass |
1/5 · collecting |
可合并 |
历史行按 run_id + run_attempt 去重并只增不删；删除本评论后可由 gate_terminal 制品重建。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llm.share_card_model/llm.share_card_reasoning_effort，写法与notes_model同构。summary_model/summary_reasoning_effort，与改动前行为一致。selected_models改为读share_card_*键，不再读summary_model键。Test plan
uv run --frozen pytest -q tests/llm/test_share_card_processor.pyuv run --frozen pytest -q tests -k "share_card or config"from_dict缺省回退行后test_uses_summary_model_and_schema以 AssertionError 转红，已还原Made with Cursor