Repository navigation
修复空转录成功缓存及撤权后的摘要请求 - #263
Merged
Merged
Conversation
Agent-Executor: codex-lead Agent-Session: 01a1480f-4908-7eb2-8738-ca17d4f23775
Required Gate v2 — 状态面板当前状态:pass · 可合并 当前裁决: PR 累计主审轮(影子): Gate 历史(v1;来源为持久化
|
| Run | Attempt | Head | 状态 | PR 累计主审轮(影子) | 收件人动作 |
|---|---|---|---|---|---|
| 39003390059 | 1 | 250e8e9 |
skipped |
— |
无需动作(主审未跑,绿≠过审) |
| 39005559770 | 1 | 5eab9f1 |
fail |
— |
要修代码 |
| 39005579872 | 1 | 5eab9f1 |
pass |
— |
可合并 |
| 39006414418 | 1 | c29326f |
fail |
— |
要修代码 |
| 39007647198 | 1 | 2b99891 |
pass |
3/5 · collecting |
可合并 |
历史行按 run_id + run_attempt 去重并只增不删;删除本评论后可由 gate_terminal 制品重建。
zj1123581321
marked this pull request as ready for review
October 17, 2026 05:15
Agent-Executor: codex-lead Agent-Session: 01a1480f-4908-7eb2-8738-ca17d4f23775
Agent-Executor: codex-lead Agent-Session: 01a1480f-4908-7eb2-8738-ca17d4f23775
Agent-Executor: codex-lead Agent-Session: 01a1480f-4908-7eb2-8738-ca17d4f23775
Agent-Executor: codex-lead Agent-Session: 01a1480f-4908-7eb2-8738-ca17d4f23775
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243
This PR prevents empty transcripts from being treated as successful cache entries or handed to downstream consumers.
EmptyTranscriptErrorbefore cache or handoff.Valid numeric FunASR text, numeric subtitles preserved in structured segments, existing valid cache rows, and the revoked-token 404 contract remain covered.
Accepted P2: if opening or reading an already-written CapsWriter
.txtfile raises an I/O error, the existing reader logs a warning and may continue with an empty value. This PR covers empty or whitespace-only producer output and successfully-read bodies, not that separate read-I/O failure path. Already-issued summary requests are not aborted. A detached row that retainsdata-vtafter an unrelated list redraw can still send its existing pending request; this existing behavior is unchanged.Validation:
uv run pytest -q tests/integration/test_issue243_empty_transcript.py— 10 passed.uv run pytest -q tests/unit/test_capswriter_contract.py— 24 passed.uv run pytest -q tests/integration/test_local_upload_lifecycle.py::test_public_read_summary_exports_and_owner_history_close_without_content_bypass— 1 passed.