Skip to content

🔧 chore(deps): retain TypeScript compatibility for Astro checks - #83

Closed
zrr1999 wants to merge 4 commits into
codex/website-validation-20261003from
codex/typescript-compatibility-guard
Closed

zrr1999 wants to merge 4 commits into
codex/website-validation-20261003from
codex/typescript-compatibility-guard

Conversation

@zrr1999

@zrr1999 zrr1999 commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

动机

仓库当前的构建入口仍使用 astro check,并明确将 TypeScript 固定在 6.x。直接接受 Renovate 的 TypeScript 7 原生编译器升级,会超出现有检查流程的兼容范围,已有升级 PR #54 暴露了这一问题。

解决方案

为 Renovate 的 typescript 包增加 allowedVersions: "<7",阻止未经验证的主版本升级,同时继续允许 TypeScript 6.x 的补丁和次版本更新。

说明

本 PR 仅修改 Renovate 候选版本规则,不升级依赖、不改写 lockfile,也不移除 astro check。上游已推进 Content Mapper 等新检查方式;本限制针对本仓库当前工具链,后续完成迁移并验证构建后再移除。兼容性背景见 withastro/astro#17268。

所属原生 stack 为 #86,直接基线是 #82,后续为 #84、#85。#54 保留为现有升级记录,其后续状态由 Renovate 规则和维护流程决定。

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
zrr-website-slides 9292a6a Commit Preview URL

Branch Preview URL
Oct 18 2026, 12:57 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
zrr-website-blog 9292a6a Commit Preview URL

Branch Preview URL
Oct 18 2026, 12:58 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
zrr-website-root 9292a6a Commit Preview URL

Branch Preview URL
Oct 18 2026, 12:59 PM

@morirun morirun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已审阅 #83 至 952aa2f。

阻塞项:

  • 无。

非阻塞:

  • PR 正文的「动机」「解决方案」用英文写成,与中文模板和其余 stack PR 不一致,建议统一为中文。
  • 该规则生效后,Renovate 通常会关闭不再符合 allowedVersions 的 #54;如需保留跟踪 TS 7 的入口,可另开 issue 关联 withastro/astro#17268,在上游支持后移除此规则。

核对:

  • allowedVersions: "<7" 与 AGENTS.md、pnpm-workspace.yaml catalog 中「TypeScript 钉在 6.x」的约束一致,只限制 typescript 一个包,TS 6 的补丁与次版本更新不受影响。
  • 将 #82、#83 合并到当前 main 后本地 vp run build 通过(含博客 astro check,0 errors)。
  • CI 全绿。

结论:

  • Approve。

@gitar-bot

gitar-bot Bot commented Oct 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Restricting Renovate to TypeScript versions below 7 could delay compiler fixes and compatibility improvements until Astro supports the native compiler.

Limits Renovate's TypeScript candidates to <7 so the Astro language server keeps working with the TypeScript programmatic API, while TS 6 patch and minor updates remain eligible and astro check stays in the build. No issues found.

Review coverage

📋 Rules No rules evaluated

🧪 Functional validation Not enabled · Set up

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

@zrr1999
zrr1999 marked this pull request as ready for review October 18, 2026 13:04
@zrr1999 zrr1999 closed this Oct 18, 2026
@zrr1999
zrr1999 removed this pull request from stack #86 October 18, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants