Repository navigation
feat(query): 查询结果行数上限与 schema include_system 修复 - #85
Merged
Merged
Conversation
Add RFC 0017 with default caps (CLI/Web 1000, MCP 500), early-stop scanning, truncation metadata, and optional MCP response byte guard. Fix MySQL/PG include_system listing and empty tables JSON arrays. Co-authored-by: x_zhuo <zx06@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
- Coverage 84.47% 84.23% -0.25%
==========================================
Files 69 74 +5
Lines 6744 6970 +226
==========================================
+ Hits 5697 5871 +174
- Misses 765 802 +37
- Partials 282 297 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Resolve merge conflicts (RFC 0015–0017, query executeQuery+dbType). Reuse HintQueryResultTruncated from internal/errors after PR #84. Co-authored-by: x_zhuo <zx06@users.noreply.github.com>
Co-authored-by: x_zhuo <zx06@users.noreply.github.com>
Co-authored-by: x_zhuo <zx06@users.noreply.github.com>
Co-authored-by: x_zhuo <zx06@users.noreply.github.com>
- MCP max_rows 0 = unset; negative rejected; clamp via mcp.max_rows_limit (10k) - truncated_reason, max_response_bytes; preserve configured max_rows on byte trim - Binary-search MCP byte fitting; CSV truncation notice on stderr - Align docs/RFC; reduce Sonar complexity in include_system test Co-authored-by: x_zhuo <zx06@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Query result row limits (RFC 0017) with early-stop scanning, truncation metadata, MCP byte guard, and schema
include_systemfixes.中文摘要
max_rows: 0= 未设置(走默认链),负值拒绝。mcp.max_rows_limit(默认 10000) clamp 超大请求,metadata 含max_rows_requested/max_rows_limit。truncated_reason(max_rows/max_response_bytes)、max_rows为配置上限、max_response_bytes、合并hint。internal/errors/hints.go一致。Testing
go build/go vet/go test ./.../ integration (MySQL 8.0, PG 16) / e2e / golangci-lint