Repository navigation
[pull] master from eycorsican:master - #34
Merged
Merged
Conversation
Datagram::split() takes the inner datagram and then drops the wrapper, which notified the cleanup task and retired the session counters right when traffic was about to start. Only end the session on drop if the datagram was never split; once split, the recv/send halves drive retirement through move_to_recent. Add tests for both paths.
The entered span guard was held across the await of the connection handler, so the span stayed entered on the thread while the task yielded and unrelated tasks were attributed to it. The span variable was also shadowed right after the guard was taken. Scope the guard to the debug log and keep a single span.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )