Milestone 9b: choose hulls and assemble the wing before launch - #32
Merged
Merged
Conversation
Signed-off-by: Stephen DeLorme <stephen@d.elor.me>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sbddesign
marked this pull request as ready for review
September 6, 2026 18:16
Signed-off-by: Stephen DeLorme <stephen@d.elor.me>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players can choose a hull before joining and see the same wing roster while the host prepares to launch.
?hostkeeps two seats;?host=3or?host=4adds seats. Host hull changes and departures reach every waiting browser. Launch preserves each reserved seat and hull, including gaps left by departing peers; late arrivals take over an existing AI ship without changing its hull.The headless lobby owns reservations over the existing WebRTC channel. Protocol v2 adds a hull to HELLO and a revisioned LOBBY frame. Repeated hellos repair lost roster/launch messages, older rosters cannot roll back newer choices, and incompatible versions prompt a reload. Returning the host to the hangar closes the old wing and creates a fresh code. Hangar controls retain native Tab/Space behavior; flight keeps its target-switch keys.
Merged current main's BFG change at
a45858d. Both the BFG and lobby tests are retained, with the combined assertion count resolved to 699. The BFG controls and native menu keyboard handling are preserved.Validation:
a45858d: typecheck, 699 simulation checks, balance contract and production build pass. Full mutation gate: 132/132 caught, zero survivors or untestable cases.e74a47c: real Chrome/WebRTC workflow passed on one Mac: keyboard copy/select, matching rosters, host hull update, leave → AI, rejoin → launch in reserved Drone seat, and host abort → fresh code. Desktop, phone-width and joined-state captures reviewed; all three UI review findings resolved.1dac6ae, incorporating this exact lobby merge, also passes real Chrome/WebRTC join, launch, Wasp firing and BFG gun interlock checks in separate browser processes with 100 ms each-way delay.Two separate physical devices have not been retested. The existing ICE recovery behavior is unchanged.
Try
?host=4, copy the join link, pick Drone in the joining browser, and press JOIN WING. Both lists should show P2 / Drone / JOINED. Change the host hull, leave/rejoin, then launch: the guest should enter flight in that Drone.