fix: preserve final timestep when resampling trajectories - #3
Open
kejan2514 wants to merge 4 commits into
Open
Conversation
|
Reviewed the patch — I reproduced the bug on
One minor nit: in the The included regression tests cover the two main behaviors nicely. From my side this looks safe to merge — leaving the maintainer to confirm the design choice (strict-uniform vs exact-landing), which the linked issue #2 asks about. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes trajectory resampling so that the final timestep is always preserved.
Previously,
np.arange()could exclude the trajectory endpoint when the time range was not evenly divisible bytarget_dt.Changes
target_dtdivides the interval exactlyTesting
Added tests covering: