fix(ci): keep upstream theme assets LF-normalized - #1735
Open
Rat0323 wants to merge 1 commit into
Open
Conversation
This was referenced Jul 31, 2026
Rat0323
added a commit
to Rat0323/CodexPlusPlus
that referenced
this pull request
Aug 4, 2026
Mirror PR BigPizzaV3#1735 so byte-exact upstream theme asset tests pass on Windows checkouts; this commit becomes a no-op once BigPizzaV3#1735 merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
theme.jsonfiles to LFRoot cause
The
upstream_theme_assets.rstests hash raw file bytes. The previous.gitattributesrules covered only part of the tested assets, so Windows checkouts converted uncovered LF files to CRLF and caused byte-exact hash failures.The upstream
maincommit01c69a8reproduced the issue before these feature changes were involved:https://github.com/BigPizzaV3/CodexPlusPlus/actions/runs/30603754154
The failing hashes match the CRLF-transformed bytes, while the expected hashes match the repository LF bytes.
Validation
cargo test -p codex-plus-core --test upstream_theme_assets --lockedgit diff --checkupstream_theme_assets.rsresolves totext eol=lfThis is a repository-level maintenance fix for #1732.
Closes #1732.