Repository navigation
Protect FAT backup files with a durable transfer warning - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On exFAT/FAT, the old copy fallback claimed an empty destination name and then renamed a temporary file over it. Another writer could replace that claim between the identity check and rename, or have its replacement deleted during failure cleanup. This change removes that race for media files: BitMatch durably saves a visible, per-attempt warning before creating final filenames with exclusive create. An interrupted copy leaves its partial file and incomplete warning in place; existing destination files are never replaced or deleted.
The warning is checked before each new file, periodically during long writes, and before the result is accepted. It records file-evidence status only. Independent destination readback, exact selected-file coverage, named-file identity checks, ASC MHL/report work, and the journal still determine the final verdict. Compare and Check recognize only exact, valid destination status files; a same-named source file stays selected data. Unrecognized filesystems without safe hard-link publication fail closed. APFS publication is unchanged.
Local validation:
F_FULLFSYNCand root-directoryfsyncreturned success.FAT32 could not be mounted on this Mac (
hdiutil: Device not configured), so FAT32 filesystem behavior and physical-drive/power-loss behavior remain unverified. This does not establish the cause of issue #10. The separate ASC MHL empty-directory claim race is tracked indocs/TODO.md.