Repository navigation
feat(mobile): float the Android chat header and mask both chat edges like iOS - #2394
Conversation
…like iOS Android's chat header now floats over the messages with a round Back, the title chip as its own island and a round computer button. The drawn edge fade becomes a mask layer between the list and the floating chrome: nearly opaque under the composer and the header, then the light edge curve, in the chat's own background colour, with an explicit top-to-bottom gradient so it no longer renders reversed above the composer. The composer's + is a filled round button on the field's raised fill. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QxWnExdvT58a8MeXHJ7aRn
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QxWnExdvT58a8MeXHJ7aRn
Captured on the Xiaomi phone (Android 16, HyperOS 3, zh-CN) running a Release build of main d220792, light and dark: a Bot DM at its newest message and scrolled so text passes under the composer and the header, the same on a solid colour chat background, the group chat header and a held back gesture. finding-name-capsule-clipped-after- theme-switch-light shows the name capsule truncated after a dark-to-light switch while the app was open; it renders correctly after a restart. Status bar redacted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QxWnExdvT58a8MeXHJ7aRn
…anges (#2416) * fix(mobile): remount the Android chat title when its theme or name changes The floating header's title chip kept the width it was first measured at, so after switching between light and dark in the chat it clipped the Bot's name to its first letter. Keying the title on the scheme, font scale and name makes the native header measure it again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QxWnExdvT58a8MeXHJ7aRn * docs(changes): Android chat title fragment Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QxWnExdvT58a8MeXHJ7aRn * docs(pr-screenshots): Android phone QA shots for #2394 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QxWnExdvT58a8MeXHJ7aRn --------- Co-authored-by: Claude <noreply@anthropic.com>
|
Android phone result (Xiaomi, Android 16 / HyperOS 3, isolated QA Host, deepseek-v4.1-flash), release build of main d220792 Screenshots: 2394-android-chat-chrome/phone (commit 90552c1): DM at rest and scrolled, on default and coloured backgrounds, group header and back gesture, light and dark. Findings: the name chip collapsed to "M…" after a theme switch inside the chat ( Generated by Claude Code |
Keep main's floating Android header fill (#2394); this PR now only swaps Back to the Material arrow. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QbudM552v4qrLMzopz7j7k
Requested by Vain · project thread
Why the change
On Android the chat's bottom fade stopped above the composer (messages under the + stayed fully visible), the header was a flat Material bar, and + had no container. iOS already matches the Grok reference; this brings Android in line / 安卓聊天页底部渐变卡在输入框上方,顶部是平铺的 Material 栏,+ 没有背景;对齐 iOS 已实现的 Grok 设计。
Special things to note
Platform.OS === 'android'). iOS and web paths are unchanged.ScrollView'sfadingEdgeLengthfades content linearly at the scroll view's own bounds, so it can't keep what passes under floating chrome hidden. So Android keeps a drawn fade, now as a mask layer between the list and the composer/header.0 → 1, with the stops mirrored for the bottom edge. Phone QA showed text still visible under the composer. The root cause was the SVG'sheight="100%"keeping its first, shorter height. fix(mobile): draw the chat's bottom mask on iOS instead of UIKit's edge effect #2398 fixed that on main by sizing the SVG to its height.Change outline
headerTransparent, with a round Back, the avatar+name chip as its own island and a round computer button. The list pads its own top by the header height.EdgeFadegainscover+color. It stays nearly opaque under the composer/header, then runs the lightedgeFadecurve, in the chat's background colour. A top fade is added.raisedfill.Phone QA (Xiaomi, Android 16 / HyperOS 3, release build)
https://github.com/BotHarness/DeepSeekBot/blob/daa30b764d884169c461f3a6af29df253e61f5a9/.github/pr-screenshots/2394-android-chat-chrome/phone/dm-latest-light.png?raw=true"width="240">https://github.com/BotHarness/DeepSeekBot/blob/daa30b764d884169c461f3a6af29df253e61f5a9/.github/pr-screenshots/2394-android-chat-chrome/phone/dm-latest-dark.png?raw=true"width="240">https://github.com/BotHarness/DeepSeekBot/blob/daa30b764d884169c461f3a6af29df253e61f5a9/.github/pr-screenshots/2394-android-chat-chrome/phone/dm-scrolled-light.png?raw=true"width="240">https://github.com/BotHarness/DeepSeekBot/blob/daa30b764d884169c461f3a6af29df253e61f5a9/.github/pr-screenshots/2394-android-chat-chrome/phone/dm-scrolled-dark.png?raw=true"width="240">https://github.com/BotHarness/DeepSeekBot/blob/daa30b764d884169c461f3a6af29df253e61f5a9/.github/pr-screenshots/2394-android-chat-chrome/phone/dm-colored-scrolled-light.png?raw=true"width="240">https://github.com/BotHarness/DeepSeekBot/blob/daa30b764d884169c461f3a6af29df253e61f5a9/.github/pr-screenshots/2394-android-chat-chrome/phone/dm-colored-scrolled-dark.png?raw=true"width="240">https://github.com/BotHarness/DeepSeekBot/blob/daa30b764d884169c461f3a6af29df253e61f5a9/.github/pr-screenshots/2394-android-chat-chrome/phone/group-header-light.png?raw=true"width="240">https://github.com/BotHarness/DeepSeekBot/blob/daa30b764d884169c461f3a6af29df253e61f5a9/.github/pr-screenshots/2394-android-chat-chrome/phone/group-header-dark.png?raw=true"width="240">QA findings:
finding-name-capsule-clipped-after-theme-switch-light.png). The fix is in fix(mobile): remount the Android chat title when its theme or name changes #2416.🤖 Generated with Claude Code
https://claude.ai/code/session_01QxWnExdvT58a8MeXHJ7aRn