Repository navigation
feat(mobile): render Host sections and responsive Pinned chats - #2574
Merged
Merged
Conversation
Issue: #2571 Agent-Task: codex/local/01a16238-8539-71a1-8975-89042bd66eb7
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 25
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 22, 2026
Preserve the original pinned-grid head and current main row-menu and encrypted route coverage. Remove prohibited comments and explicitly assert settings refresh reads alongside group mutations. Issue: #2571 Agent-Task: codex/local/01a16587-3995-7b22-8c81-7c19caccddef
Contributor
Author
Agent work outcome — source merged; native qualification handed off
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2571 | Original claim | Integration claim
Why the change
Phone Chats flattens Remote Host organization, so this slice shows canonical sections and a responsive Pinned grid while preserving ordinary row actions and flat search.
Special things to note
265cb6f5c995). This PR now targetsmain; a normal merge preserves original headda0a53c937e5and current main's row menus, swipe, peek, section creation and encrypted route checks. Organize/drag and unpin-plus-assign remain outside this slice.settings/describereads affect mobile and Web Remote Host loading; review canonical order, failed-refresh retention and Host/Cloud separation. Settings-only Web changes appear after refresh/reconnect.Change outline
Pinned cards omit preview/time and retain opening, iOS preview, native menu and accessibility actions. Unpin restores original membership; empty Pinned is hidden and empty custom sections remain visible. Failed refresh retains confirmed roster/sorting and exposes retry.
CI repairs: remove newly introduced prohibited comments; distinguish nine group mutations from nine
settings/describerefresh reads with explicit assertions. Merge conflicts retain main's two-platform row-menu tests and Connect refusal tests. Android search adds its missing BackHandler fixture; iOS preview assertions follow the actual sibling tree. No test skipped or gate weakened.Validation at
05ba0bd873c21dddec4bdefd49e8587e04fe7b55: 206 focused tests across 12 files passed; root and mobile typechecks, source policy, ledger, feature-map and CLI-parity checks passed. CI 39858838507 passed all applicable jobs and the aggregate: static/type/build, three full test shards, mobile verification, Android native module tests, docs and isolated Host smoke. Shared Web regressions passed locally. No local full-suite or native build was run; actual device qualification remains with the allocated QA lane.Visual evidence pending: the shared Simulator/native build is reserved for the earlier frozen account/Send cut. No competing device session was started. Next-batch review follows
phone-pinned-grid: no/custom sections, pin/unpin return, sort/collapse/search, Host switching and All/Cloud separation, ordinary row actions, keyboard/accessibility, width and default/intermediate/maximum text × light/dark on iOS and Android, plus shared Web loading. Source fixtures do not establish native layout acceptance. The refreshed exact-head HTML is a local review aid; reviewer-accessible publication remains unavailable.Original implementation:
codex/local/01a16238-8539-71a1-8975-89042bd66eb7Integration and CI repair:
codex/local/01a16587-3995-7b22-8c81-7c19caccddef