Enhance safe path input validation and traversal tests - #395
Conversation
Normalize backslashes to forward slashes in `validate_safe_path` before checking path components to ensure cross-platform parent directory traversal protection, and add additional tests for path traversal.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Enhanced
validate_safe_pathinserver_manager/src/core/validate.rsto normalize backslashes to forward slashes before parsing path components, protecting against Windows-style path traversal sequences. Added accompanying test cases inserver_manager/tests/contract_input_validation.rs. Verified all tests, lints, and security checks pass with./verify.sh.PR created automatically by Jules for task 1519102276614721322 started by @Cylae