Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server_manager/src/core/validate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ pub fn validate_ip(ip_str: &str) -> Result<IpAddr> {
/// Validates that a path does not contain directory traversal sequences (`..`).
pub fn validate_safe_path<P: AsRef<Path>>(path: P) -> Result<P> {
let p = path.as_ref();
for comp in p.components() {
let normalized = p.to_string_lossy().replace('\\', "/");
let norm_path = Path::new(&normalized);
for comp in norm_path.components() {
if comp == Component::ParentDir {
bail!(
"Validation error: path traversal forbidden in '{}'",
Expand Down
7 changes: 7 additions & 0 deletions server_manager/tests/contract_input_validation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,10 @@ fn test_validate_safe_path() {
assert!(validate_safe_path(Path::new("/opt/server_manager/../../etc/shadow")).is_err());
assert!(validate_safe_path(Path::new("a/b/../../../etc/passwd")).is_err());
}

#[test]
fn test_validate_safe_path_extended_traversal() {
assert!(validate_safe_path(Path::new("..\\secret")).is_err());
assert!(validate_safe_path(Path::new("..")).is_err());
assert!(validate_safe_path(Path::new(".")).is_ok());
}
Loading