🔒 Fix argument injection vulnerability in run_cli_toggle - #407
Conversation
Insert `--` before passing the positional service argument to std::process::Command. This guarantees that clap and other argument parsers interpret service as a positional value rather than a command-line flag or option, preventing argument injection.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Fixed potential argument injection in
run_cli_toggleby explicitly inserting--option delimiter before positional service parameter when spawning child CLI process.--delimiter, a service name string starting with hyphens (e.g.,--optionor-h) could be parsed as CLI flags/options byclapinstead of positional values.🛡️ Solution: Updated
Command::new(exe).arg(action).arg("--").arg(service)to ensure argument parsing treatsservicestrictly as a positional argument, and added unit test coverage inserver_manager/src/interface/web.rs.PR created automatically by Jules for task 2775550130301488844 started by @Cylae