Skip to content

🔒 Fix argument injection vulnerability in run_cli_toggle #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Cylae wants to merge 1 commit into from
Closed

🔒 Fix argument injection vulnerability in run_cli_toggle #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion server_manager/src/interface/web.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,7 +1383,7 @@ fn run_cli_toggle(service: &str, enable: bool) {
info!("Web UI triggering: server_manager {} {}", action, service);

if let Ok(exe) = std::env::current_exe() {
match Command::new(exe).arg(action).arg(service).spawn() {
match Command::new(exe).arg(action).arg("--").arg(service).spawn() {
Ok(mut child) => {
// Spawn a background task to wait for the child process to exit.
// This prevents zombie processes by collecting the exit status.
Expand Down Expand Up @@ -1932,3 +1932,17 @@ async fn audit_page(session: Session) -> impl IntoResponse {
write_html_foot(&mut html);
Html(html).into_response()
}

#[cfg(test)]
mod tests {
#[test]
fn test_run_cli_toggle_command_args() {
let action = "enable";
let service = "plex";
let mut cmd = std::process::Command::new("server_manager");
cmd.arg(action).arg("--").arg(service);

let args: Vec<&std::ffi::OsStr> = cmd.get_args().collect();
assert_eq!(args, vec!["enable", "--", "plex"]);
}
}
Loading