Skip to content

🔒 Fix Command Execution with relative useradd path - #411

Closed
Cylae wants to merge 1 commit into
mainfrom
fix/useradd-absolute-path-13098466155646312693
Closed

🔒 Fix Command Execution with relative useradd path#411
Cylae wants to merge 1 commit into
mainfrom
fix/useradd-absolute-path-13098466155646312693

Conversation

@Cylae

@Cylae Cylae commented Sep 9, 2026

Copy link
Copy Markdown
Owner

🎯 What:
Replaced Command::new("useradd") with absolute path /usr/sbin/useradd in server_manager/src/core/system.rs and added a unit test module validating username input sanitization.

⚠️ Risk:
Using relative executable names in Command::new relies on $PATH resolution. If an attacker gains control over $PATH or writes to a directory preceding /usr/sbin in $PATH, they could hijack execution when creating system users.

🛡️ Solution:
Updating Command::new("useradd") to /usr/sbin/useradd guarantees execution of the trusted system binary regardless of environment $PATH overrides.


PR created automatically by Jules for task 13098466155646312693 started by @Cylae

Replace Command::new("useradd") with absolute path Command::new("/usr/sbin/useradd") in server_manager/src/core/system.rs to eliminate risk of binary hijacking via PATH manipulation. Added unit test suite for username input validation.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Cylae Cylae closed this Sep 13, 2026
@Cylae
Cylae deleted the fix/useradd-absolute-path-13098466155646312693 branch September 13, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant