Skip to content

🔒 Fix Command Execution with relative useradd path #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Cylae wants to merge 1 commit into from
Closed

🔒 Fix Command Execution with relative useradd path #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion server_manager/src/core/system.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ pub fn create_system_user(username: &str, password: &str) -> Result<()> {

info!("Creating system user '{}'...", username);
// useradd -m -s /bin/bash <username>
let status = Command::new("useradd")
let status = Command::new("/usr/sbin/useradd")
.arg("-m")
.arg("-s")
.arg("/bin/bash")
Expand Down Expand Up @@ -309,3 +309,17 @@ net.core.wmem_max=1048576

Ok(())
}

#[cfg(test)]
mod tests {
use super::*;

#[test]
fn test_validate_username() {
assert!(validate_username("valid_user").is_ok());
assert!(validate_username("valid-user-123").is_ok());
assert!(validate_username("").is_err());
assert!(validate_username("invalid user").is_err());
assert!(validate_username("user;id").is_err());
}
}
Loading