Repository navigation
feat(ui): show the bitrate the PAD takes, default PAD 40 for new services - #55
Merged
Merged
Conversation
…ices The PAD is reserved in every AU, so its cost depends on the codec and the sample rate: HE-AAC = 25 AU/s at 48 kHz (16.7 at 32 kHz), AAC-LC = twice that. With the old default of 58 bytes, an 88 kbps HE-AAC service lost 11.6 kbps (13 %) to the PAD, and an AAC-LC service at 96 kbps lost 23 kbps. - The hint beside the PAD field now shows the PAD bitrate, its share of the service bitrate and what is left for the audio, then the slide send times. These are computed with the real AU rate (the old hint assumed 24 AU/s). It turns yellow above 20 % and follows bitrate / codec / sample rate changes. - New services get PAD 40 bytes (a 15 kB cover still goes out in ~16 s). Existing services and the server-side fallback keep 58. - PAD 0 is explained (odr-audioenc then sends no DLS and no slides). - Sizes odr-padenc rejects (1-5, 7, >196) are refused on save: odr-padenc exits on them. Frontend only: no server, preset or ODR command change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The PAD is reserved in every AU, so it is taken from the audio bitrate. With the old default of 58 bytes:
These figures were checked in the DAB+ superframes produced by odr-audioenc 3.6.0: 25 AU/s for HE-AAC at 48 kHz, 16.7 AU/s at 32 kHz, 50 AU/s for AAC-LC. A bench on 4 live sources (72 to 96 kbps, HE-AAC v1, slideshow running) measured the perceptual distortion compared with PAD 58: −6 to −11 % with PAD 40, and −9 to −15 % with PAD 32. With PAD 40, a 15 kB cover goes out in about 16 s, against 11 s with PAD 58.
What changes (frontend only)
appState.js) andcommandBuilder.jsstill use 58, so old presets are untouched.min="0").Safety
web/app.js+web/index.htmlonly. No change to the server, the preset format,/api/state, the ODR command lines or anything ON AIR.appState.jsstill estimates the logo rotation timing with 24 AU/s. That is a separate subsystem and is left unchanged on purpose.runtime/) next to production.🤖 Generated with Claude Code